Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2971153002: Drop inspector jumbo excludes as they are not needed (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
fs, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop inspector jumbo excludes as they are not needed Some files excluded from jumbo compilation seems to compile just fine in jumbo so this patch removes their special treatment. Review-Url: https://codereview.chromium.org/2971153002 Cr-Commit-Position: refs/heads/master@{#486000} Committed: https://chromium.googlesource.com/chromium/src/+/331c8e962f8c38c0476c206e922768fa9f5255e7

Patch Set 1 #

Total comments: 1

Patch Set 2 : Dropping temporary testing code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Daniel Bratell
https://codereview.chromium.org/2971153002/diff/1/build/config/jumbo.gni File build/config/jumbo.gni (right): https://codereview.chromium.org/2971153002/diff/1/build/config/jumbo.gni#newcode10 build/config/jumbo.gni:10: use_jumbo_build = !is_official_build && !(is_android && !is_clang) Temporary for ...
3 years, 5 months ago (2017-07-06 15:15:53 UTC) #6
Daniel Bratell
On 2017/07/06 15:15:53, Daniel Bratell wrote: > https://codereview.chromium.org/2971153002/diff/1/build/config/jumbo.gni > File build/config/jumbo.gni (right): > > https://codereview.chromium.org/2971153002/diff/1/build/config/jumbo.gni#newcode10 ...
3 years, 5 months ago (2017-07-12 14:38:13 UTC) #9
Daniel Bratell
3 years, 5 months ago (2017-07-12 14:39:06 UTC) #10
fs
lgtm
3 years, 5 months ago (2017-07-12 14:43:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971153002/20001
3 years, 5 months ago (2017-07-12 15:02:57 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 17:00:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/331c8e962f8c38c0476c206e9227...

Powered by Google App Engine
This is Rietveld 408576698