Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2971123002: Adjust action button styling in MD notification. (Closed)

Created:
3 years, 5 months ago by tetsui
Modified:
3 years, 5 months ago
Reviewers:
yoshiki, fukino
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust action button styling in MD notification. Adjusted action button syling to match the mock in MD notification. * Capitalized the button label string. * Centered the button label string. BUG=739269, 739270 TEST=manual Review-Url: https://codereview.chromium.org/2971123002 Cr-Commit-Position: refs/heads/master@{#484840} Committed: https://chromium.googlesource.com/chromium/src/+/b6c9801027065551008297762dacd1b6631e3aa1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ui/message_center/views/notification_view_md.cc View 1 4 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
tetsui
PTAL. Thanks!
3 years, 5 months ago (2017-07-06 05:42:06 UTC) #4
fukino
lgtm
3 years, 5 months ago (2017-07-06 11:54:32 UTC) #7
tetsui
fukino@: Thanks! yoshiki@: PTAL for OWNERS review.
3 years, 5 months ago (2017-07-07 01:43:11 UTC) #8
yoshiki
lgtm with nit https://codereview.chromium.org/2971123002/diff/1/ui/message_center/views/notification_view_md.cc File ui/message_center/views/notification_view_md.cc (right): https://codereview.chromium.org/2971123002/diff/1/ui/message_center/views/notification_view_md.cc#newcode224 ui/message_center/views/notification_view_md.cc:224: // visible_opacity of InkDropHighlight. could you ...
3 years, 5 months ago (2017-07-07 02:50:53 UTC) #9
tetsui
yoshiki@: Thanks! https://codereview.chromium.org/2971123002/diff/1/ui/message_center/views/notification_view_md.cc File ui/message_center/views/notification_view_md.cc (right): https://codereview.chromium.org/2971123002/diff/1/ui/message_center/views/notification_view_md.cc#newcode224 ui/message_center/views/notification_view_md.cc:224: // visible_opacity of InkDropHighlight. On 2017/07/07 02:50:53, ...
3 years, 5 months ago (2017-07-07 04:00:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971123002/20001
3 years, 5 months ago (2017-07-07 04:00:44 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 05:44:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b6c9801027065551008297762dac...

Powered by Google App Engine
This is Rietveld 408576698