Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2971093003: [wasm] Remove the use of private symbols for branding. (Closed)

Created:
3 years, 5 months ago by titzer
Modified:
3 years, 5 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove the use of private symbols for branding. Instead, rely on the underlying instance types for WebAssembly.* types. R=clemensh@chromium.org, rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2971093003 Cr-Commit-Position: refs/heads/master@{#46478} Committed: https://chromium.googlesource.com/v8/v8/+/01148639575ffd76270b8db30cbff20a39a37555

Patch Set 1 #

Patch Set 2 : [wasm] Remove the use of private symbols for branding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -115 lines) Patch
M src/contexts.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/wasm/module-compiler.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/wasm/wasm-js.cc View 12 chunks +29 lines, -99 lines 0 comments Download
M src/wasm/wasm-objects.cc View 4 chunks +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
titzer
3 years, 5 months ago (2017-07-06 15:27:18 UTC) #1
titzer
On 2017/07/06 15:27:18, titzer wrote: PTAL rossberg
3 years, 5 months ago (2017-07-07 08:37:19 UTC) #6
rossberg
lgtm
3 years, 5 months ago (2017-07-07 08:52:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971093003/20001
3 years, 5 months ago (2017-07-07 12:52:18 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 12:56:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/01148639575ffd76270b8db30cbff20a39a...

Powered by Google App Engine
This is Rietveld 408576698