Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2971083002: gpu: Reduce direct use of BrowserGpuMemoryBufferManager (Closed)

Created:
3 years, 5 months ago by sadrul
Modified:
3 years, 5 months ago
Reviewers:
Sam McNally, jbauman, piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Reduce direct use of BrowserGpuMemoryBufferManager. . BrowserGpuMemoryBufferManager register itself as a dump-provider to MemoryDumpManager upon creation. . Instead of getting the list of supported native gpu memory buffer configurations from BrowserGpuMemoryBufferManager, generate the list directly in GpuInternalUI. This is called only when the chrome:gpu page is loaded. So this should happen rarely enough that this should not introduce any latency, or any other kind of regression. BUG=733482 Review-Url: https://codereview.chromium.org/2971083002 Cr-Commit-Position: refs/heads/master@{#485480} Committed: https://chromium.googlesource.com/chromium/src/+/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 2

Patch Set 7 : . #

Total comments: 4

Patch Set 8 : . #

Patch Set 9 : tot merge #

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 2 3 3 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 58 (44 generated)
sadrul
sammc@ Could you please look at the change related to BrowserGpuChannelHostFactory::CloseChannel()? From what I can ...
3 years, 5 months ago (2017-07-06 07:34:49 UTC) #15
jbauman
https://codereview.chromium.org/2971083002/diff/100001/content/browser/gpu/browser_gpu_memory_buffer_manager.cc File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2971083002/diff/100001/content/browser/gpu/browser_gpu_memory_buffer_manager.cc#newcode78 content/browser/gpu/browser_gpu_memory_buffer_manager.cc:78: // BrowserProcessSubThread::IOThreadPreCleanUp). This comment about unregistration is incorrect now. ...
3 years, 5 months ago (2017-07-06 21:39:18 UTC) #16
sadrul
https://codereview.chromium.org/2971083002/diff/100001/content/browser/gpu/browser_gpu_memory_buffer_manager.cc File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2971083002/diff/100001/content/browser/gpu/browser_gpu_memory_buffer_manager.cc#newcode78 content/browser/gpu/browser_gpu_memory_buffer_manager.cc:78: // BrowserProcessSubThread::IOThreadPreCleanUp). On 2017/07/06 21:39:18, jbauman wrote: > This ...
3 years, 5 months ago (2017-07-06 23:38:18 UTC) #19
jbauman
lgtm
3 years, 5 months ago (2017-07-07 00:20:02 UTC) #20
Sam McNally
On 2017/07/06 07:34:49, sadrul wrote: > sammc@ Could you please look at the change related ...
3 years, 5 months ago (2017-07-07 01:12:08 UTC) #21
sadrul
+piman@ for browser_main_loop.cc owner On 2017/07/07 01:12:08, Sam McNally wrote: > On 2017/07/06 07:34:49, sadrul ...
3 years, 5 months ago (2017-07-07 02:09:47 UTC) #25
piman
https://codereview.chromium.org/2971083002/diff/120001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (left): https://codereview.chromium.org/2971083002/diff/120001/content/browser/browser_main_loop.cc#oldcode1233 content/browser/browser_main_loop.cc:1233: BrowserGpuChannelHostFactory::instance()->CloseChannel(); I'm surprised we don't need this. The GpuChannelHost ...
3 years, 5 months ago (2017-07-07 03:57:10 UTC) #31
piman
3 years, 5 months ago (2017-07-07 03:57:12 UTC) #32
sadrul
https://codereview.chromium.org/2971083002/diff/120001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (left): https://codereview.chromium.org/2971083002/diff/120001/content/browser/browser_main_loop.cc#oldcode1233 content/browser/browser_main_loop.cc:1233: BrowserGpuChannelHostFactory::instance()->CloseChannel(); On 2017/07/07 03:57:10, piman wrote: > I'm surprised ...
3 years, 5 months ago (2017-07-08 03:19:33 UTC) #41
chromium-reviews
On Fri, Jul 7, 2017 at 8:19 PM, <sadrul@chromium.org> wrote: > > https://codereview.chromium.org/2971083002/diff/120001/ > content/browser/browser_main_loop.cc ...
3 years, 5 months ago (2017-07-10 20:58:08 UTC) #42
sadrul
On 2017/07/10 20:58:08, chromium-reviews wrote: > On Fri, Jul 7, 2017 at 8:19 PM, <mailto:sadrul@chromium.org> ...
3 years, 5 months ago (2017-07-10 23:04:29 UTC) #45
piman
lgtm
3 years, 5 months ago (2017-07-10 23:06:02 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971083002/200001
3 years, 5 months ago (2017-07-11 01:10:23 UTC) #54
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 01:16:52 UTC) #58
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/d30c3532f0cead481b8ef4c7290e...

Powered by Google App Engine
This is Rietveld 408576698