Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Issue 2971073002: Use same_document term instead of same_page in FrameNavigationState (Closed)

Created:
3 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 5 months ago
Reviewers:
nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use same_document term instead of same_page in FrameNavigationState Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2971073002 Cr-Commit-Position: refs/heads/master@{#487623} Committed: https://chromium.googlesource.com/chromium/src/+/eb728dc805a10d6a216b740bc9ece7b9443feded

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 5 months ago (2017-07-06 00:12:50 UTC) #6
nasko
LGTM and thanks for the cleanup!
3 years, 5 months ago (2017-07-18 18:57:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971073002/1
3 years, 5 months ago (2017-07-18 20:19:31 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 22:04:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb728dc805a10d6a216b740bc9ec...

Powered by Google App Engine
This is Rietveld 408576698