Added force refresh to the config set page.

config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832
Review-Url: https://codereview.chromium.org/2971033003
Committed: https://github.com/luci/luci-py/commit/32c3d35dd963a5798200fbbdf18f9025317ec5e8

[cwpayton, 2017-07-05 23:32:41]

cwpayton@google.com changed reviewers:
+ hinoka@chromium.org, sergeyberezin@chromium.org

[cwpayton, 2017-07-05 23:32:42]

Added force refresh to config set page. PTAL

[cwpayton, 2017-07-05 23:32:55]

Description was changed from

==========
Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832
==========

to

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832
==========

[Ryan Tseng, 2017-07-05 23:45:01]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-07-05 23:45:02]

Do you have a link or screenshot?

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
File appengine/config_service/ui/bower.json (right):

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
appengine/config_service/ui/bower.json:31: "paper-styles": "1 - 2",
Make this an exact version

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
File appengine/config_service/ui/src/config-ui/config-set.html (right):

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
appengine/config_service/ui/src/config-ui/config-set.html:131:
setTimeout(function() {
I don't think we'll need this, error messages should just persist until
dismissed.

[cwpayton, 2017-07-05 23:46:25]

Description was changed from

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832
==========

to

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately. Changes can
be viewed here:
https://2949-d64d67a-tainted-cwpayton-dot-luci-config.appspot.com/newui#/

BUG=730832
==========

[cwpayton, 2017-07-06 02:03:40]

PTAL

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
File appengine/config_service/ui/bower.json (right):

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
appengine/config_service/ui/bower.json:31: "paper-styles": "1 - 2",
On 2017/07/05 23:45:02, Ryan Tseng wrote:
> Make this an exact version

Done.

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
File appengine/config_service/ui/src/config-ui/config-set.html (right):

https://codereview.chromium.org/2971033003/diff/20001/appengine/config_servic...
appengine/config_service/ui/src/config-ui/config-set.html:131:
setTimeout(function() {
On 2017/07/05 23:45:02, Ryan Tseng wrote:
> I don't think we'll need this, error messages should just persist until
> dismissed.

Done.

[Ryan Tseng, 2017-07-06 18:27:11]

lg but don't put the demo link in the description, just put it in the message. 
The reason is that the demo link is ephemeral and shouldn't show up in the git
history, but it is useful for review.

https://codereview.chromium.org/2971033003/diff/40001/appengine/config_servic...
File appengine/config_service/ui/src/config-ui/config-set.html (right):

https://codereview.chromium.org/2971033003/diff/40001/appengine/config_servic...
appengine/config_service/ui/src/config-ui/config-set.html:64: <iron-icon
icon="icons:refresh" on-tap="_forceRefresh"></iron-icon>
Show this only if the user is logged in

[cwpayton, 2017-07-06 18:32:41]

Description was changed from

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately. Changes can
be viewed here:
https://2949-d64d67a-tainted-cwpayton-dot-luci-config.appspot.com/newui#/

BUG=730832
==========

to

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832
==========

[cwpayton, 2017-07-06 19:06:52]

PTAL. Changes can be viewed here:
https://2949-d64d67a-tainted-cwpayton-dot-luci-config.appspot.com/newui

[Ryan Tseng, 2017-07-06 19:49:15]

lgtm

[cwpayton, 2017-07-06 20:03:33]

The CQ bit was checked by cwpayton@google.com

[commit-bot: I haz the power, 2017-07-06 20:03:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 20:05:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499371413791520,
"parent_rev": "1ee4458e1c1732abfd229b6267aaf364d99e8f23", "commit_rev":
"32c3d35dd963a5798200fbbdf18f9025317ec5e8"}

[commit-bot: I haz the power, 2017-07-06 20:05:50]

Description was changed from

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832
==========

to

==========
config_service: Added force refresh to the config set page.

Users can now force refresh the list of config files within a given config
set if they would like to see their changes propogated immediately.

BUG=730832

Review-Url: https://codereview.chromium.org/2971033003
Committed:
https://github.com/luci/luci-py/commit/32c3d35dd963a5798200fbbdf18f9025317ec5e8
==========

[commit-bot: I haz the power, 2017-07-06 20:05:51]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/32c3d35dd963a5798200fbbdf18f9025317ec5e8