Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2971003002: [Payment Request] Queries application locale from payments::PaymentRequest (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
macourteau
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Queries application locale from payments::PaymentRequest Gets rid of cases in which the application locale was being queried from the global ApplicationContext instance. BUG=602666 Review-Url: https://codereview.chromium.org/2971003002 Cr-Commit-Position: refs/heads/master@{#485041} Committed: https://chromium.googlesource.com/chromium/src/+/807879a191895d9acc2a9230c3fadfc5273cfd38

Patch Set 1 : Initial #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -48 lines) Patch
M ios/chrome/browser/payments/payment_request.mm View 1 4 chunks +4 lines, -7 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_unittest.mm View 1 4 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator.mm View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm View 1 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_mediator.mm View 5 chunks +4 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_mediator_unittest.mm View 1 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_coordinator.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm View 1 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm View 4 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator.mm View 3 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_manager.mm View 5 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
Moe
Hi MAC, Please take a look at this CL.
3 years, 5 months ago (2017-07-06 14:18:59 UTC) #8
macourteau
Nice cleanup! lgtm.
3 years, 5 months ago (2017-07-07 20:13:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971003002/60001
3 years, 5 months ago (2017-07-07 20:13:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/807879a191895d9acc2a9230c3fadfc5273cfd38
3 years, 5 months ago (2017-07-07 20:54:57 UTC) #15
Moe
3 years, 5 months ago (2017-07-08 03:40:28 UTC) #16
Message was sent while issue was closed.
On 2017/07/07 at 20:54:57, commit-bot wrote:
> Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/807879a191895d9acc2a9230c3fa...

Thank you.

Powered by Google App Engine
This is Rietveld 408576698