Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2970903002: Remove unusable test: editing/selection/selection-actions.html (Closed)

Created:
3 years, 5 months ago by yoichio
Modified:
3 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unusable test: editing/selection/selection-actions.html The test was introduced 12 ago to confirm user key navigation not crash (I guess it came from "VisiblePosition" traversing): https://chromium.googlesource.com/chromium/src/+/41b612685b1d71129123b1ae4ffd5c1a240327af However all methods in the test calls Selection.modify(). We test that method behavior in addition to not crashing in layout tests. Thus, we don't need the layout test just confirming not crash. BUG=739062 Review-Url: https://codereview.chromium.org/2970903002 Cr-Commit-Position: refs/heads/master@{#484194} Committed: https://chromium.googlesource.com/chromium/src/+/37deacfdee01657c0451e7a24ecdc8456cb49626

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
yoichio
3 years, 5 months ago (2017-07-05 04:51:48 UTC) #5
yosin_UTC9
lgtm Good catch!
3 years, 5 months ago (2017-07-05 05:14:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970903002/1
3 years, 5 months ago (2017-07-05 05:14:43 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 06:06:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37deacfdee01657c0451e7a24ecd...

Powered by Google App Engine
This is Rietveld 408576698