Description was changed from ========== Remove unusable LayoutTest BUG=739062 ========== to ========== Remove unusable test: ...
3 years, 5 months ago
(2017-07-05 04:51:28 UTC)
#3
Description was changed from
==========
Remove unusable LayoutTest
BUG=739062
==========
to
==========
Remove unusable test: editing/selection/selection-actions.html
The test was introduced 12 ago to confirm user key navigation not crash
(I guess it came from "VisiblePosition" traversing):
https://chromium.googlesource.com/chromium/src/+/41b612685b1d71129123b1ae4ffd...
However all methods in the test calls Selection.modify(). We test that
method behavior in addition to not crashing in layout tests.
Thus, we don't need the layout test just confirming not crash.
BUG=739062
==========
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1499231669163660, "parent_rev": "70b9dcb8dae67c7c101a1c4c8f17da2adbcf98ab", "commit_rev": "37deacfdee01657c0451e7a24ecdc8456cb49626"}
3 years, 5 months ago
(2017-07-05 06:06:19 UTC)
#10
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499231669163660, "parent_rev":
"70b9dcb8dae67c7c101a1c4c8f17da2adbcf98ab", "commit_rev":
"37deacfdee01657c0451e7a24ecdc8456cb49626"}
commit-bot: I haz the power
Description was changed from ========== Remove unusable test: editing/selection/selection-actions.html The test was introduced 12 ago ...
3 years, 5 months ago
(2017-07-05 06:06:39 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Remove unusable test: editing/selection/selection-actions.html
The test was introduced 12 ago to confirm user key navigation not crash
(I guess it came from "VisiblePosition" traversing):
https://chromium.googlesource.com/chromium/src/+/41b612685b1d71129123b1ae4ffd...
However all methods in the test calls Selection.modify(). We test that
method behavior in addition to not crashing in layout tests.
Thus, we don't need the layout test just confirming not crash.
BUG=739062
==========
to
==========
Remove unusable test: editing/selection/selection-actions.html
The test was introduced 12 ago to confirm user key navigation not crash
(I guess it came from "VisiblePosition" traversing):
https://chromium.googlesource.com/chromium/src/+/41b612685b1d71129123b1ae4ffd...
However all methods in the test calls Selection.modify(). We test that
method behavior in addition to not crashing in layout tests.
Thus, we don't need the layout test just confirming not crash.
BUG=739062
Review-Url: https://codereview.chromium.org/2970903002
Cr-Commit-Position: refs/heads/master@{#484194}
Committed:
https://chromium.googlesource.com/chromium/src/+/37deacfdee01657c0451e7a24ecd...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/37deacfdee01657c0451e7a24ecdc8456cb49626
3 years, 5 months ago
(2017-07-05 06:06:40 UTC)
#12
Issue 2970903002: Remove unusable test: editing/selection/selection-actions.html
(Closed)
Created 3 years, 5 months ago by yoichio
Modified 3 years, 5 months ago
Reviewers: yosin_UTC9
Base URL:
Comments: 0