Separate out animations tests with prefixing

Group together tests of prefixed animation code

This patch moves animations layout tests that specifically test
webkit-prefixed code into their own subdirectory. Other uses of
the webkit-prefix are removed where possible.

BUG=623434
Review-Url: https://codereview.chromium.org/2970883003
Cr-Commit-Position: refs/heads/master@{#484501}
Committed: https://chromium.googlesource.com/chromium/src/+/5b71f29a85b372045e943b5e178f3898485186bc

[suzyh_UTC10 (ex-contributor), 2017-07-05 05:28:12]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-07-05 05:28:44]

This one is still a WIP. What do you think of the resulting organization?

[suzyh_UTC10 (ex-contributor), 2017-07-05 05:28:52]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 05:29:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-07-05 05:35:27]

I don't understand the distinction between prefixed and uses-prefixed-code. Does
there need to be one?

[commit-bot: I haz the power, 2017-07-05 06:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 06:45:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[suzyh_UTC10 (ex-contributor), 2017-07-06 00:22:57]

On 2017/07/05 at 05:35:27, alancutter wrote:
> I don't understand the distinction between prefixed and uses-prefixed-code.
Does there need to be one?

The distinction I was going for is "deliberately tests prefixed behaviour" vs
"happens to use prefixed code, but ideally would be fixed to not do that". I was
judging this based on whether the test explicitly had "prefixed" in the filename
or not.

[alancutter (OOO until 2018), 2017-07-06 01:55:55]

On 2017/07/06 at 00:22:57, suzyh wrote:
> On 2017/07/05 at 05:35:27, alancutter wrote:
> > I don't understand the distinction between prefixed and uses-prefixed-code.
Does there need to be one?
> 
> The distinction I was going for is "deliberately tests prefixed behaviour" vs
"happens to use prefixed code, but ideally would be fixed to not do that". I was
judging this based on whether the test explicitly had "prefixed" in the filename
or not.

I don't think "happens to use prefixed code" is a very useful category, such
tests would be better categorised under the functionality they're intending to
test. Let it be implicit that prefix usage outside of the "prefixed" directory
is a TODO to fix up.

[suzyh_UTC10 (ex-contributor), 2017-07-06 04:37:24]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 04:37:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[suzyh_UTC10 (ex-contributor), 2017-07-06 04:42:42]

Description was changed from

==========
Separate out animations tests with prefixing

This patch moves animations layout tests that rely on or are testing
webkit-prefixed code into their own subdirectories.

BUG=623434
==========

to

==========
Group together tests of prefixed animation code

This patch moves animations layout tests that specifically test
webkit-prefixed code into their own subdirectory. Other uses of
the webkit-prefix are removed where possible.

BUG=623434
==========

[suzyh_UTC10 (ex-contributor), 2017-07-06 04:45:25]

On 2017/07/06 at 01:55:55, alancutter wrote:
> On 2017/07/06 at 00:22:57, suzyh wrote:
> > On 2017/07/05 at 05:35:27, alancutter wrote:
> > > I don't understand the distinction between prefixed and
uses-prefixed-code. Does there need to be one?
> > 
> > The distinction I was going for is "deliberately tests prefixed behaviour"
vs "happens to use prefixed code, but ideally would be fixed to not do that". I
was judging this based on whether the test explicitly had "prefixed" in the
filename or not.
> 
> I don't think "happens to use prefixed code" is a very useful category, such
tests would be better categorised under the functionality they're intending to
test. Let it be implicit that prefix usage outside of the "prefixed" directory
is a TODO to fix up.

That makes sense. I've moved those tests back to the top-level directory.

I've rebaselined the images for one of the tests and updated the CL description,
so this patch is now basically ready, supposing the dry run passes.

If there are any tests where I've removed a prefix but you think the test is
intending to specifically test the prefixed code, please let me know.

[alancutter (OOO until 2018), 2017-07-06 04:48:20]

lgtm

[suzyh_UTC10 (ex-contributor), 2017-07-06 04:50:21]

The CQ bit was unchecked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-07-06 04:50:23]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-07-06 04:50:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[suzyh_UTC10 (ex-contributor), 2017-07-06 05:43:17]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-07-06 05:43:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2970883003/#ps80001
(title: "Rebaseline virtual/threaded version of test too")

[commit-bot: I haz the power, 2017-07-06 05:43:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 08:49:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499319797125410,
"parent_rev": "aa4c54cbd611f55c475eda159865c7134442f71c", "commit_rev":
"5b71f29a85b372045e943b5e178f3898485186bc"}

[commit-bot: I haz the power, 2017-07-06 08:49:25]

Description was changed from

==========
Group together tests of prefixed animation code

This patch moves animations layout tests that specifically test
webkit-prefixed code into their own subdirectory. Other uses of
the webkit-prefix are removed where possible.

BUG=623434
==========

to

==========
Group together tests of prefixed animation code

This patch moves animations layout tests that specifically test
webkit-prefixed code into their own subdirectory. Other uses of
the webkit-prefix are removed where possible.

BUG=623434

Review-Url: https://codereview.chromium.org/2970883003
Cr-Commit-Position: refs/heads/master@{#484501}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b71f29a85b372045e943b5e178f...
==========

[commit-bot: I haz the power, 2017-07-06 08:49:26]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5b71f29a85b372045e943b5e178f...