Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2970883002: Reduce memory usage in DelayedPersistentAllocation. (Closed)

Created:
3 years, 5 months ago by bcwhite
Modified:
3 years, 5 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce memory usage in DelayedPersistentAllocation. The PMA is limited to 32-bit values so it's known that |size| and |offset| can't exceed that. No need to waste space on 64-bit builds. BUG=733380 Review-Url: https://codereview.chromium.org/2970883002 Cr-Commit-Position: refs/heads/master@{#484158} Committed: https://chromium.googlesource.com/chromium/src/+/4e72a1554a6b4efb3ea711ead4876f0f3e276e45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M base/metrics/persistent_memory_allocator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/persistent_memory_allocator.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
bcwhite
3 years, 5 months ago (2017-07-04 20:12:10 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 5 months ago (2017-07-04 20:13:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970883002/1
3 years, 5 months ago (2017-07-04 20:14:56 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 21:13:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e72a1554a6b4efb3ea711ead487...

Powered by Google App Engine
This is Rietveld 408576698