Fix underline/overline flipping

Fix underline/overline flipping

Underline/overline flipping logic is triggered as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic to handle such cases.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2970803002
Cr-Commit-Position: refs/heads/master@{#484174}
Committed: https://chromium.googlesource.com/chromium/src/+/fe56c88d9d01183d5ac0f53ea901ff66e5d2d644

[kojii, 2017-07-04 08:00:54]

Description was changed from

==========
line-through

BUG=
==========

to

==========
line-through

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-07-04 08:01:04]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 08:01:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-07-04 08:03:22]

Description was changed from

==========
line-through

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix underline/overline flipping

Underline/overline flipping logic is kicked as defined in the spec[1].
The logic, however, did not take cases where both are off, or both are
on.

This patch fixes the flipping logic.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-07-04 08:04:14]

Description was changed from

==========
Fix underline/overline flipping

Underline/overline flipping logic is kicked as defined in the spec[1].
The logic, however, did not take cases where both are off, or both are
on.

This patch fixes the flipping logic.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix underline/overline flipping

Underline/overline flipping logic is kicked as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-07-04 08:04:27]

Description was changed from

==========
Fix underline/overline flipping

Underline/overline flipping logic is kicked as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix underline/overline flipping

Underline/overline flipping logic is kicked as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic to handle such cases.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-07-04 08:04:38]

kojii@chromium.org changed reviewers:
+ drott@chromium.org

[kojii, 2017-07-04 08:04:39]

PTAL.

[commit-bot: I haz the power, 2017-07-04 09:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 09:47:14]

Dry run: This issue passed the CQ dry run.

[drott, 2017-07-04 18:23:44]

LGTM, with a nit:

> Underline/overline flipping logic is kicked as defined in the spec[1].

You probably mean "triggered", could you please update the description? Thanks
for the test case.

[kojii, 2017-07-05 01:41:18]

Description was changed from

==========
Fix underline/overline flipping

Underline/overline flipping logic is kicked as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic to handle such cases.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix underline/overline flipping

Underline/overline flipping logic is triggered as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic to handle such cases.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-07-05 01:42:05]

Thank you for prompt review and great advice!

[kojii, 2017-07-05 01:42:07]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-07-05 01:42:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 01:45:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499218927967240, "parent_rev":
"4d76ff5f3e0dd3177c72c5e848ff40349375c41e", "commit_rev":
"fe56c88d9d01183d5ac0f53ea901ff66e5d2d644"}

[commit-bot: I haz the power, 2017-07-05 01:45:53]

Description was changed from

==========
Fix underline/overline flipping

Underline/overline flipping logic is triggered as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic to handle such cases.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix underline/overline flipping

Underline/overline flipping logic is triggered as defined in the spec[1].
The logic, however, did not handle cases where both are off, or both are
on correctly.

This patch fixes the flipping logic to handle such cases.

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=738778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2970803002
Cr-Commit-Position: refs/heads/master@{#484174}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe56c88d9d01183d5ac0f53ea901...
==========

[commit-bot: I haz the power, 2017-07-05 01:45:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe56c88d9d01183d5ac0f53ea901...