Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2970793002: MD Bookmarks: Always use a two-way arrow cursor for resizing the sidebar (Closed)

Created:
3 years, 5 months ago by tsergeant
Modified:
3 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Always use a two-way arrow cursor for resizing the sidebar This changes the cursor on the sidebar to 'e-resize' on Windows and 'col-resize' on other platforms, which results in always showing a two-way arrow. This matches the behavior of the old bookmark manager on Windows and Mac, while Linux (Ubuntu, at least) changes from a one-way arrow to a two-way arrow. BUG=737153 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2970793002 Cr-Commit-Position: refs/heads/master@{#484225} Committed: https://chromium.googlesource.com/chromium/src/+/5aad1d965b804500e9c6a1fb82625353f3df8f33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/app.html View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tsergeant
Just a little CSS change.
3 years, 5 months ago (2017-07-04 07:57:51 UTC) #3
calamity
lgtm
3 years, 5 months ago (2017-07-05 03:05:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970793002/1
3 years, 5 months ago (2017-07-05 07:03:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/463131) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 5 months ago (2017-07-05 08:15:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970793002/1
3 years, 5 months ago (2017-07-05 08:22:48 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 09:32:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5aad1d965b804500e9c6a1fb8262...

Powered by Google App Engine
This is Rietveld 408576698