Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2970773002: Convert editing/selection/3690719.html using assert_selection(). (Closed)

Created:
3 years, 5 months ago by yoichio
Modified:
3 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, danakj+watch_chromium.org, grt+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/3690719.html using assert_selection(). 3690719 was introduced to confirm select all behavior in content editable: https://chromium.googlesource.com/chromium/src/+/8c8a84b04e24083fc6729245cb2681c569f13485 We don't need test it on the google page. TEST=LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html BUG=739062, 679977 Review-Url: https://codereview.chromium.org/2970773002 Cr-Commit-Position: refs/heads/master@{#484080} Committed: https://chromium.googlesource.com/chromium/src/+/417c8e572bca610c9e92003f50ea6b9339a3da5a

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Total comments: 2

Patch Set 4 : update #

Messages

Total messages: 19 (13 generated)
yoichio
3 years, 5 months ago (2017-07-04 06:43:34 UTC) #4
yoichio
3 years, 5 months ago (2017-07-04 07:56:03 UTC) #8
yosin_UTC9
lgtm w/ nit https://codereview.chromium.org/2970773002/diff/40001/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html File third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html (right): https://codereview.chromium.org/2970773002/diff/40001/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html#newcode10 third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html:10: selection => { nit: s/selection => ...
3 years, 5 months ago (2017-07-04 08:15:00 UTC) #10
yoichio
https://codereview.chromium.org/2970773002/diff/40001/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html File third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html (right): https://codereview.chromium.org/2970773002/diff/40001/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html#newcode10 third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_in_contenteditable.html:10: selection => { On 2017/07/04 08:15:00, yosin_UTC9 wrote: > ...
3 years, 5 months ago (2017-07-04 08:43:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970773002/60001
3 years, 5 months ago (2017-07-04 08:43:54 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 10:01:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/417c8e572bca610c9e92003f50ea...

Powered by Google App Engine
This is Rietveld 408576698