Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2970623002: [WIP] Compute the linkMatchType inside the CSSSelectorParser.

Created:
3 years, 5 months ago by Hwanseung Lee
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Compute the linkMatchType inside the CSSSelectorParser. Store the linkMatchType on the first CSSSelector in each CSSSelectorList instead of computing it every time we build the RuleSets. BUG=585651

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : [WIP] Compute the linkMatchType inside the CSSSelectorParser. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/CSSSelector.h View 1 5 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserSelector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (12 generated)
Hwanseung Lee
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
3 years, 5 months ago (2017-07-02 07:54:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970623002/1
3 years, 5 months ago (2017-07-02 07:54:53 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-02 09:00:50 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/492498)
3 years, 5 months ago (2017-07-02 09:00:55 UTC) #4
Hwanseung Lee
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
3 years, 5 months ago (2017-07-09 11:00:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970623002/20001
3 years, 5 months ago (2017-07-09 11:00:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-09 12:54:48 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/495162)
3 years, 5 months ago (2017-07-09 12:54:49 UTC) #8
Hwanseung Lee
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
3 years, 5 months ago (2017-07-19 13:27:46 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970623002/40001
3 years, 5 months ago (2017-07-19 13:27:58 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-19 15:01:56 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 15:01:57 UTC) #12 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698