Simplify condition to use libc++ [Take 2]

Simplify condition to use libc++ [Take 2]

This CL simplifies use_custom_libcxx.  Most of the sanitizers are only
used on Linux so those cases can be removed.

BUG=593874
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng

Review-Url: https://codereview.chromium.org/2970593002
Cr-Commit-Position: refs/heads/master@{#483866}
Committed: https://chromium.googlesource.com/chromium/src/+/cbab88489dff618fe1b8c4b9a8e192c1a5e1883a

[Tom Anderson, 2017-06-30 21:42:51]

Description was changed from

==========
Simplify condition to use libc++ [Take 2]

This CL simplifies use_custom_libcxx.  Most of the sanitizers are only
used on Linux so those cases can be removed.

BUG=593874
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

to

==========
Simplify condition to use libc++ [Take 2]

This CL simplifies use_custom_libcxx.  Most of the sanitizers are only
used on Linux so those cases can be removed.

BUG=593874
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng
==========

[Tom Anderson, 2017-06-30 21:45:10]

thakis ptal

The reason the other CL was wrong was because msan requires is_linux, but my
condition to use libc++ was is_linux && !is_chromeos.  This CL adds CrOs msan
and asan to the CQ too.

I still think we should enable libc++ on CrOs too, then we could avoid similar
issues

[Tom Anderson, 2017-06-30 21:50:21]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 21:50:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-06-30 22:30:56]

Lgtm

I agree we should use this in CrOS too, at least when doing the cros-on-linux
build. One thing at a time though :-)

[commit-bot: I haz the power, 2017-06-30 23:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 23:45:30]

Dry run: This issue passed the CQ dry run.

[Tom Anderson, 2017-06-30 23:48:22]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-06-30 23:48:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 23:53:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498866502068750, "parent_rev":
"056af850c5c366189914185b41f78a50148b3036", "commit_rev":
"cbab88489dff618fe1b8c4b9a8e192c1a5e1883a"}

[commit-bot: I haz the power, 2017-06-30 23:53:22]

Description was changed from

==========
Simplify condition to use libc++ [Take 2]

This CL simplifies use_custom_libcxx.  Most of the sanitizers are only
used on Linux so those cases can be removed.

BUG=593874
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng
==========

to

==========
Simplify condition to use libc++ [Take 2]

This CL simplifies use_custom_libcxx.  Most of the sanitizers are only
used on Linux so those cases can be removed.

BUG=593874
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng

Review-Url: https://codereview.chromium.org/2970593002
Cr-Commit-Position: refs/heads/master@{#483866}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbab88489dff618fe1b8c4b9a8e1...
==========

[commit-bot: I haz the power, 2017-06-30 23:53:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbab88489dff618fe1b8c4b9a8e1...