Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2970463002:
ChromeOS: Enable Gaia v2 API by default. (Closed)
|
Created:
3 years, 5 months ago by Alexander Alekseev Modified:
3 years, 5 months ago Reviewers:
jdufault CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChromeOS: Enable Gaia v2 API by default.
BUG=709244
Review-Url: https://codereview.chromium.org/2970463002
Cr-Original-Commit-Position: refs/heads/master@{#483877}
Committed: https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd236d628ee9f3
Review-Url: https://codereview.chromium.org/2970463002
Cr-Commit-Position: refs/heads/master@{#486617}
Committed: https://chromium.googlesource.com/chromium/src/+/264e791e873bf3ffd104a820597bfadb429e048b
Patch Set 1 #
Total comments: 2
Patch Set 2 : Update after review. #Messages
Total messages: 31 (17 generated)
alemate@chromium.org changed reviewers: + jdufault@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2970463002/diff/1/chrome/browser/ui/webui/chr... File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2970463002/diff/1/chrome/browser/ui/webui/chr... chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:358: } else if (use_easy_bootstrap_) { Can this be // Easy bootstrap is not v2-compatible. if (base::CommandLine... || use_easy_bootstrap_) { // use api v1 } else { // use api v2 }
https://codereview.chromium.org/2970463002/diff/1/chrome/browser/ui/webui/chr... File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2970463002/diff/1/chrome/browser/ui/webui/chr... chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:358: } else if (use_easy_bootstrap_) { On 2017/06/30 18:48:19, jdufault wrote: > Can this be > > // Easy bootstrap is not v2-compatible. > if (base::CommandLine... || use_easy_bootstrap_) { > // use api v1 > } > else { > // use api v2 > } Done.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, thanks.
The CQ bit was unchecked by alemate@chromium.org
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498863595153400,
"parent_rev": "f762d2d7fae21aa756013a35e4612281c0cbb054", "commit_rev":
"30815d143e71eb731bea80ba5fbd236d628ee9f3"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 ========== to ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2970463002 Cr-Commit-Position: refs/heads/master@{#483877} Committed: https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd...
Message was sent while issue was closed.
On 2017/07/01 00:48:42, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... I suspect this is breaking tests, is it possible to revert ?
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2971273002/ by alemate@chromium.org. The reason for reverting is: bvt cheets_EnterpriseLogin test is failing on caroline..
Message was sent while issue was closed.
On 2017/07/07 02:31:38, Junichi Uekawa wrote: > On 2017/07/01 00:48:42, commit-bot: I haz the power wrote: > > Committed patchset #2 (id:20001) as > > > https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... > > I suspect this is breaking tests, is it possible to revert ? It looks like reverting did not help and this test is still broken. Should I apply it back?
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2970463002 Cr-Commit-Position: refs/heads/master@{#483877} Committed: https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... ========== to ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2970463002 Cr-Commit-Position: refs/heads/master@{#483877} Committed: https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... ==========
Fix for the test has landed to catapult. Re-enabling Gaia v2 by default.
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499994475586190,
"parent_rev": "68f8319bf3d53dbd8f0322e61f22f293fef4f38d", "commit_rev":
"264e791e873bf3ffd104a820597bfadb429e048b"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2970463002 Cr-Commit-Position: refs/heads/master@{#483877} Committed: https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... ========== to ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2970463002 Cr-Original-Commit-Position: refs/heads/master@{#483877} Committed: https://chromium.googlesource.com/chromium/src/+/30815d143e71eb731bea80ba5fbd... Review-Url: https://codereview.chromium.org/2970463002 Cr-Commit-Position: refs/heads/master@{#486617} Committed: https://chromium.googlesource.com/chromium/src/+/264e791e873bf3ffd104a820597b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/264e791e873bf3ffd104a820597b... |
