Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2970453003:
Add support for facingMode in MediaStreamTrack.getSettings() on Android. (Closed)
|
Created:
3 years, 5 months ago by Guido Urdaneta Modified:
3 years, 5 months ago Reviewers:
hbos_chromium CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd support for facingMode in MediaStreamTrack.getSettings() on Android.
BUG=734078
Review-Url: https://codereview.chromium.org/2970453003
Cr-Commit-Position: refs/heads/master@{#484510}
Committed: https://chromium.googlesource.com/chromium/src/+/f6eca8a125174a843cd9271ca83b60dd4390cd19
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix comment #Messages
Total messages: 22 (14 generated)
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add support for facingMode in MediaStreamTrack.getSettings() on Android. BUG=734078 ========== to ========== Add support for facingMode in MediaStreamTrack.getSettings() on Android. BUG=734078 ==========
guidou@chromium.org changed reviewers: + hbos@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi, PTAL
lgtm
https://codereview.chromium.org/2970453003/diff/1/content/renderer/media/medi... File content/renderer/media/media_stream_video_track.cc (right): https://codereview.chromium.org/2970453003/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_video_track.cc:432: // On Android, the facing mode is not available in the |facing| field, nit: video_facing field
The CQ bit was checked by guidou@chromium.org
The CQ bit was unchecked by guidou@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by guidou@chromium.org
The CQ bit was unchecked by guidou@chromium.org
The CQ bit was checked by guidou@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org Link to the patchset: https://codereview.chromium.org/2970453003/#ps20001 (title: "fix comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2970453003/diff/1/content/renderer/media/medi... File content/renderer/media/media_stream_video_track.cc (right): https://codereview.chromium.org/2970453003/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_video_track.cc:432: // On Android, the facing mode is not available in the |facing| field, On 2017/07/05 10:21:04, hbos_chromium wrote: > nit: video_facing field Done.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499329186281900,
"parent_rev": "f81b40e3e1af7d9c45d98451df0e314714319f91", "commit_rev":
"f6eca8a125174a843cd9271ca83b60dd4390cd19"}
Message was sent while issue was closed.
Description was changed from ========== Add support for facingMode in MediaStreamTrack.getSettings() on Android. BUG=734078 ========== to ========== Add support for facingMode in MediaStreamTrack.getSettings() on Android. BUG=734078 Review-Url: https://codereview.chromium.org/2970453003 Cr-Commit-Position: refs/heads/master@{#484510} Committed: https://chromium.googlesource.com/chromium/src/+/f6eca8a125174a843cd9271ca83b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f6eca8a125174a843cd9271ca83b... |
