Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2970443003: Print missing builtin names when using a snapshot. (Closed)

Created:
3 years, 5 months ago by georgia.kouveli
Modified:
3 years, 5 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Print missing builtin names when using a snapshot. BUG= Review-Url: https://codereview.chromium.org/2970443003 Cr-Commit-Position: refs/heads/master@{#46515} Committed: https://chromium.googlesource.com/v8/v8/+/c42a641846f2c54c60d96c98d6bb683154cb96ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/objects.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
georgia.kouveli
3 years, 5 months ago (2017-06-30 10:46:18 UTC) #2
Benedikt Meurer
lgtm
3 years, 5 months ago (2017-06-30 10:50:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970443003/1
3 years, 5 months ago (2017-06-30 10:50:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/44336)
3 years, 5 months ago (2017-06-30 10:54:01 UTC) #7
georgia.kouveli
+yangguo for src/snapshot!
3 years, 5 months ago (2017-06-30 11:18:47 UTC) #9
georgia.kouveli
On 2017/06/30 11:18:47, georgia.kouveli wrote: > +yangguo for src/snapshot! Ping?
3 years, 5 months ago (2017-07-10 12:31:46 UTC) #10
Yang
On 2017/07/10 12:31:46, georgia.kouveli wrote: > On 2017/06/30 11:18:47, georgia.kouveli wrote: > > +yangguo for ...
3 years, 5 months ago (2017-07-10 12:53:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970443003/1
3 years, 5 months ago (2017-07-10 12:58:38 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 13:24:01 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c42a641846f2c54c60d96c98d6bb683154c...

Powered by Google App Engine
This is Rietveld 408576698