Remove a bunch of URLRequestContext::Builder setters.

Remove a bunch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2970423002
Cr-Commit-Position: refs/heads/master@{#485036}
Committed: https://chromium.googlesource.com/chromium/src/+/cf3cb2ab0c07b7baf280ec82f90c426bdedbe0a7

[mmenke, 2017-07-07 18:47:45]

Description was changed from

==========
Remove a buch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
==========

to

==========
Remove a buch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-07-07 18:47:54]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 18:48:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-07 18:50:38]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 18:50:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 19:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 19:07:05]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[mmenke, 2017-07-07 19:10:57]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 19:11:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 19:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 19:27:19]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[mmenke, 2017-07-07 19:29:31]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 19:30:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-07 20:00:01]

mmenke@chromium.org changed reviewers:
+ mef@chromium.org

[mmenke, 2017-07-07 20:00:02]

Not the most exciting CL, just trying to trim down on URLRequestContextBuilder's
API a little.

https://codereview.chromium.org/2970423002/diff/60001/components/cronet/url_r...
File components/cronet/url_request_context_config.cc (left):

https://codereview.chromium.org/2970423002/diff/60001/components/cronet/url_r...
components/cronet/url_request_context_config.cc:437:
context_builder->SetSpdyAndQuicEnabled(enable_spdy, enable_quic);
I'm leaving this method on the builder for now, since it has some other
consumers, but have to switch it over here, or the
set_http_network_session_params will reset these values to default.

[mef, 2017-07-07 20:03:48]

lgtm

[mef, 2017-07-07 20:04:16]

On 2017/07/07 20:03:48, mef wrote:
> lgtm

buch -> bunch

[mmenke, 2017-07-07 20:07:29]

Description was changed from

==========
Remove a buch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove a bunch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-07-07 20:07:41]

On 2017/07/07 20:04:16, mef wrote:
> On 2017/07/07 20:03:48, mef wrote:
> > lgtm
> 
> buch -> bunch

Done

[mmenke, 2017-07-07 20:07:50]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-07-07 20:07:53]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-07-07 20:08:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 20:48:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499458073438130,
"parent_rev": "37d54e306cbf2723af12caac99dcfea8a42159e4", "commit_rev":
"cf3cb2ab0c07b7baf280ec82f90c426bdedbe0a7"}

[commit-bot: I haz the power, 2017-07-07 20:49:02]

Description was changed from

==========
Remove a bunch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove a bunch of URLRequestContext::Builder setters.

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2970423002
Cr-Commit-Position: refs/heads/master@{#485036}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf3cb2ab0c07b7baf280ec82f90c...
==========

[commit-bot: I haz the power, 2017-07-07 20:49:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cf3cb2ab0c07b7baf280ec82f90c...