Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/ui/toolbar/media_router_contextual_menu.cc

Issue 2970273002: [Media Router] Remove the extension ID getter from MRMojoImpl (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/media_router_contextual_menu.cc
diff --git a/chrome/browser/ui/toolbar/media_router_contextual_menu.cc b/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
index 684c733e063d844f76e56f6e981b96146a102f86..cfa1818ab6f0bb26563f79ed49b02f761e64a07b 100644
--- a/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
+++ b/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
@@ -9,6 +9,8 @@
#include "base/logging.h"
#include "base/metrics/user_metrics.h"
#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/media/router/event_page_request_manager.h"
+#include "chrome/browser/media/router/event_page_request_manager_factory.h"
#include "chrome/browser/media/router/media_router_factory.h"
#include "chrome/browser/media/router/mojo/media_router_mojo_impl.h"
#include "chrome/browser/profiles/profile.h"
@@ -182,17 +184,15 @@ void MediaRouterContextualMenu::ExecuteCommand(int command_id,
void MediaRouterContextualMenu::ReportIssue() {
// Opens feedback page loaded from the media router extension.
// This is temporary until feedback UI is redesigned.
- // TODO(crbug.com/597778): remove reference to MediaRouterMojoImpl
- media_router::MediaRouterMojoImpl* media_router =
- static_cast<media_router::MediaRouterMojoImpl*>(
- media_router::MediaRouterFactory::GetApiForBrowserContext(
- static_cast<content::BrowserContext*>(browser_->profile())));
- if (media_router->media_route_provider_extension_id().empty())
+ media_router::EventPageRequestManager* request_manager =
+ media_router::EventPageRequestManagerFactory::GetApiForBrowserContext(
+ browser_->profile());
+ if (request_manager->media_route_provider_extension_id().empty())
return;
- std::string feedback_url(extensions::kExtensionScheme +
- std::string(url::kStandardSchemeSeparator) +
- media_router->media_route_provider_extension_id() +
- "/feedback.html");
+ std::string feedback_url(
+ extensions::kExtensionScheme +
+ std::string(url::kStandardSchemeSeparator) +
+ request_manager->media_route_provider_extension_id() + "/feedback.html");
chrome::ShowSingletonTab(browser_, GURL(feedback_url));
}

Powered by Google App Engine
This is Rietveld 408576698