Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/ui/toolbar/media_router_contextual_menu.cc

Issue 2970273002: [Media Router] Remove the extension ID getter from MRMojoImpl (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h" 5 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/user_metrics.h" 10 #include "base/metrics/user_metrics.h"
11 #include "chrome/app/chrome_command_ids.h" 11 #include "chrome/app/chrome_command_ids.h"
12 #include "chrome/browser/media/router/event_page_request_manager.h"
13 #include "chrome/browser/media/router/event_page_request_manager_factory.h"
12 #include "chrome/browser/media/router/media_router_factory.h" 14 #include "chrome/browser/media/router/media_router_factory.h"
13 #include "chrome/browser/media/router/mojo/media_router_mojo_impl.h" 15 #include "chrome/browser/media/router/mojo/media_router_mojo_impl.h"
14 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/signin/signin_manager_factory.h" 17 #include "chrome/browser/signin/signin_manager_factory.h"
16 #include "chrome/browser/ui/browser.h" 18 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/singleton_tabs.h" 19 #include "chrome/browser/ui/singleton_tabs.h"
18 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h" 20 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
19 #include "chrome/browser/ui/toolbar/media_router_action_controller.h" 21 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
20 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h" 22 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h"
21 #include "chrome/common/pref_names.h" 23 #include "chrome/common/pref_names.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 !is_action_in_toolbar_); 177 !is_action_in_toolbar_);
176 break; 178 break;
177 default: 179 default:
178 NOTREACHED(); 180 NOTREACHED();
179 } 181 }
180 } 182 }
181 183
182 void MediaRouterContextualMenu::ReportIssue() { 184 void MediaRouterContextualMenu::ReportIssue() {
183 // Opens feedback page loaded from the media router extension. 185 // Opens feedback page loaded from the media router extension.
184 // This is temporary until feedback UI is redesigned. 186 // This is temporary until feedback UI is redesigned.
185 // TODO(crbug.com/597778): remove reference to MediaRouterMojoImpl 187 media_router::EventPageRequestManager* request_manager =
186 media_router::MediaRouterMojoImpl* media_router = 188 media_router::EventPageRequestManagerFactory::GetApiForBrowserContext(
187 static_cast<media_router::MediaRouterMojoImpl*>( 189 browser_->profile());
188 media_router::MediaRouterFactory::GetApiForBrowserContext( 190 if (request_manager->media_route_provider_extension_id().empty())
189 static_cast<content::BrowserContext*>(browser_->profile())));
190 if (media_router->media_route_provider_extension_id().empty())
191 return; 191 return;
192 std::string feedback_url(extensions::kExtensionScheme + 192 std::string feedback_url(
193 std::string(url::kStandardSchemeSeparator) + 193 extensions::kExtensionScheme +
194 media_router->media_route_provider_extension_id() + 194 std::string(url::kStandardSchemeSeparator) +
195 "/feedback.html"); 195 request_manager->media_route_provider_extension_id() + "/feedback.html");
196 chrome::ShowSingletonTab(browser_, GURL(feedback_url)); 196 chrome::ShowSingletonTab(browser_, GURL(feedback_url));
197 } 197 }
198 198
199 int MediaRouterContextualMenu::GetChangeVisibilityTextId() { 199 int MediaRouterContextualMenu::GetChangeVisibilityTextId() {
200 return is_action_in_toolbar_ ? IDS_EXTENSIONS_HIDE_BUTTON_IN_MENU 200 return is_action_in_toolbar_ ? IDS_EXTENSIONS_HIDE_BUTTON_IN_MENU
201 : IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR; 201 : IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR;
202 } 202 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698