[Media Router] Remove the extension ID getter from MRMojoImpl

[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
BUG=727993
Review-Url: https://codereview.chromium.org/2970273002
Cr-Commit-Position: refs/heads/master@{#485439}
Committed: https://chromium.googlesource.com/chromium/src/+/bae32143ddf7c4cf69f0f71e260a194648e0b27b

[takumif, 2017-07-06 18:35:43]

Description was changed from

==========
[Media Router] Move the extension ID getter to EventPageRequestManager



BUG=
==========

to

==========
[Media Router] Move the extension ID getter to EventPageRequestManager



BUG=597778
==========

[takumif, 2017-07-06 20:20:19]

Description was changed from

==========
[Media Router] Move the extension ID getter to EventPageRequestManager



BUG=597778
==========

to

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
==========

[takumif, 2017-07-06 20:21:07]

Description was changed from

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
==========

to

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
==========

[takumif, 2017-07-06 20:22:54]

takumif@chromium.org changed reviewers:
+ imcheng@chromium.org, sheretov@chromium.org

[takumif, 2017-07-06 20:22:55]

Please take a look at:
imcheng: overall
sheretov: cast_ui.cc
Thanks!

[imcheng, 2017-07-07 21:15:43]

lgtm

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_mojo_impl.h (left):

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_mojo_impl.h:117: //
TODO(crbug.com/597778): Remove this getter.
Seems this patch will fix crbug.com/727993 as well. If so, please add the bug to
this patch.

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui.h (right):

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui.h:419:
EventPageRequestManager* event_page_request_manager_;
Make the pointer const.

[takumif, 2017-07-07 21:50:11]

Description was changed from

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
==========

to

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
BUG=727993
==========

[takumif, 2017-07-07 21:58:39]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[takumif, 2017-07-07 21:58:58]

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_mojo_impl.h (left):

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_mojo_impl.h:117: //
TODO(crbug.com/597778): Remove this getter.
On 2017/07/07 21:15:43, imcheng wrote:
> Seems this patch will fix crbug.com/727993 as well. If so, please add the bug
to
> this patch.

Done.

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui.h (right):

https://codereview.chromium.org/2970273002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui.h:419:
EventPageRequestManager* event_page_request_manager_;
On 2017/07/07 21:15:43, imcheng wrote:
> Make the pointer const.

Making it a pointer to a const object. The pointer itself cannot be const
because it's set in the ctor body.

[commit-bot: I haz the power, 2017-07-07 21:58:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 23:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 23:50:01]

Dry run: This issue passed the CQ dry run.

[sheretov, 2017-07-10 20:57:03]

LGTM for chrome/browser/ui/webui

[takumif, 2017-07-10 21:46:55]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 21:47:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 23:16:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 23:16:32]

Dry run: This issue passed the CQ dry run.

[takumif, 2017-07-10 23:17:12]

The CQ bit was checked by takumif@chromium.org

[takumif, 2017-07-10 23:17:13]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2970273002/#ps40001
(title: "Address Derek's comments")

[commit-bot: I haz the power, 2017-07-10 23:17:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 23:24:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499728632749540,
"parent_rev": "f01e385c3f752c2bfd1163db74ecbf88e5390d25", "commit_rev":
"bae32143ddf7c4cf69f0f71e260a194648e0b27b"}

[commit-bot: I haz the power, 2017-07-10 23:24:26]

Description was changed from

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
BUG=727993
==========

to

==========
[Media Router] Remove the extension ID getter from MRMojoImpl

This CL removes the media_route_provider_extension_id() getter from
MediaRouterMojoImpl, which was previously being accessed by static-casting
MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is
now used.

It seems that we cannot simply hard-code the ID, since it's different between
dev and release builds of the component extension.

BUG=597778
BUG=727993

Review-Url: https://codereview.chromium.org/2970273002
Cr-Commit-Position: refs/heads/master@{#485439}
Committed:
https://chromium.googlesource.com/chromium/src/+/bae32143ddf7c4cf69f0f71e260a...
==========

[commit-bot: I haz the power, 2017-07-10 23:24:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bae32143ddf7c4cf69f0f71e260a...