Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2970263002: Fix app data clearing timeouts for PersonalDataManagerTest. (Closed)

Created:
3 years, 5 months ago by troyhildebrandt
Modified:
3 years, 5 months ago
Reviewers:
whywhat, Yaron
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix app data clearing timeouts for PersonalDataManagerTest. Was using the wrong context from InstrumentationRegistry in ClearAppDataTestRule, so now that's fixed. Also enables the temporarily disabled tests now that they work again. BUG=739575 Review-Url: https://codereview.chromium.org/2970263002 Cr-Commit-Position: refs/heads/master@{#485001} Committed: https://chromium.googlesource.com/chromium/src/+/f0f0169b8e343d9cd4b75fdde7124a475b6fab72

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 1 2 3 6 chunks +0 lines, -16 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ClearAppDataTestRule.java View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
troyhildebrandt
3 years, 5 months ago (2017-07-07 17:13:43 UTC) #7
Yaron
lgtm
3 years, 5 months ago (2017-07-07 18:12:05 UTC) #10
troyhildebrandt
3 years, 5 months ago (2017-07-07 18:16:23 UTC) #12
troyhildebrandt
3 years, 5 months ago (2017-07-07 18:46:24 UTC) #15
whywhat
lgtm
3 years, 5 months ago (2017-07-07 18:53:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970263002/60001
3 years, 5 months ago (2017-07-07 19:07:02 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 19:12:29 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f0f0169b8e343d9cd4b75fdde712...

Powered by Google App Engine
This is Rietveld 408576698