Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2970183002: color: Use ColorSpace for plumbing (Closed)

Created:
3 years, 5 months ago by ccameron
Modified:
3 years, 5 months ago
Reviewers:
hubbe
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Use ColorSpace for plumbing Clear up more instances where ICCProfile was used for plumbing when a ColorSpace would be better. TBR=hubbe BUG=735613 Review-Url: https://codereview.chromium.org/2970183002 Cr-Commit-Position: refs/heads/master@{#484409} Committed: https://chromium.googlesource.com/chromium/src/+/39b1cbc91fa0f3e57eb4f1c2f3807e24af82657a

Patch Set 1 #

Patch Set 2 : Add missed places #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M content/public/test/layouttest_support.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/test_runner/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/test_runner_for_specific_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/web_test_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970183002/20001
3 years, 5 months ago (2017-07-05 23:27:06 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 00:24:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39b1cbc91fa0f3e57eb4f1c2f380...

Powered by Google App Engine
This is Rietveld 408576698