Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 2970143002: Update test suppression for network service. (Closed)

Created:
3 years, 5 months ago by yzshen1
Modified:
3 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update test suppression for network service. Couldn't easily find any CL resulting in the failure. There were a lot of regressed test cases because of https://chromium-review.googlesource.com/c/554399/, which was later fixed. It is possible that some other regressions were introduced during that period, but hard to tell. BUG=729849 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2970143002 . Cr-Commit-Position: refs/heads/master@{#484347} Committed: https://chromium.googlesource.com/chromium/src/+/b1d2ec19fc647fbde62797e1dcdd4d43db68fcc0

Patch Set 1 #

Patch Set 2 : Merge remote-tracking branch 'refs/remotes/origin/master' into c263_update_filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970143002/1
3 years, 5 months ago (2017-07-05 17:27:07 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/456069)
3 years, 5 months ago (2017-07-05 17:29:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970143002/20001
3 years, 5 months ago (2017-07-05 17:33:40 UTC) #6
yzshen1
3 years, 5 months ago (2017-07-05 21:00:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b1d2ec19fc647fbde62797e1dcdd4d43db68fcc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698