Simplify SelectionController::UpdateSelectionForMouseDrag()

Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for Shift+Click to
simplify implementation for improving code health.

Processing of Shift+Click and mouse drag are similar, we do as following:
* Shift-Click:
1. Click to set selection base at clicked position
 selection.collapse(clickedPositon)
2. Shift+Click to extend selection to clicked position
 selection.extend(clickedPoosition)

* Mouse Drag:
1. Mouse left-button down to set selection base at mouse down position.
 selection.collapse(downPosition)
2. Mouse move, holding left-button down, to extend selection to position
where move moved.
 selection.extend(movedPosition)

Step 2 of both are same, extend to position where mouse is.

BUG=692923
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2970043002
Cr-Commit-Position: refs/heads/master@{#484836}
Committed: https://chromium.googlesource.com/chromium/src/+/8ba4cfa3d3beed403d349394e8569905381a21aa

[yosin_UTC9, 2017-07-05 08:38:23]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 08:38:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-07-05 09:35:30]

Description was changed from

==========
2017-07-05T17:37:10

BUG=692923

2017-07-05T17:36:53
==========

to

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for shift+click to
simplify implementation for improving code health.

BUG=692923
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-07-05 10:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 10:18:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2017-07-06 06:20:30]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 06:20:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 08:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 08:10:29]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-07-07 01:04:53]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 01:05:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-07-07 01:05:15]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-07-07 01:05:36]

Patchset #1 (id:20001) has been deleted

[yosin_UTC9, 2017-07-07 01:10:34]

Description was changed from

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for shift+click to
simplify implementation for improving code health.

BUG=692923
TEST=n/a; no behavior changes
==========

to

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for Shift+Click to
simplify implementation for improving code health.

Processing of Shift+Click and mouse drag are similar, we do as following:
* Shift-Click:
1. Click to set selection base at clicked position
2. Shift+Click to extend selection to clicked position

* Mouse Drag:
1. Mouse left-button down to set selection base at mouse down position.
2. Mouse move, holding left-button down, to extend selection to position
where move moved.

Step 2 of both are same, extend to position where mouse is.

BUG=692923
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-07-07 01:12:42]

Description was changed from

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for Shift+Click to
simplify implementation for improving code health.

Processing of Shift+Click and mouse drag are similar, we do as following:
* Shift-Click:
1. Click to set selection base at clicked position
2. Shift+Click to extend selection to clicked position

* Mouse Drag:
1. Mouse left-button down to set selection base at mouse down position.
2. Mouse move, holding left-button down, to extend selection to position
where move moved.

Step 2 of both are same, extend to position where mouse is.

BUG=692923
TEST=n/a; no behavior changes
==========

to

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for Shift+Click to
simplify implementation for improving code health.

Processing of Shift+Click and mouse drag are similar, we do as following:
* Shift-Click:
1. Click to set selection base at clicked position
 selection.collapse(clickedPositon)
2. Shift+Click to extend selection to clicked position
 selection.extend(clickedPoosition)

* Mouse Drag:
1. Mouse left-button down to set selection base at mouse down position.
 selection.collapse(downPosition)
2. Mouse move, holding left-button down, to extend selection to position
where move moved.
 selection.extend(movedPosition)

Step 2 of both are same, extend to position where mouse is.

BUG=692923
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-07-07 01:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 01:26:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[yosin_UTC9, 2017-07-07 02:06:30]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2017-07-07 02:06:31]

PTAL

[yoichio, 2017-07-07 04:53:12]

lgtm

[yosin_UTC9, 2017-07-07 05:08:29]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-07-07 05:08:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 05:12:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499404109052140,
"parent_rev": "5cd334f5bb536f421a3321921b5543b02ce34534", "commit_rev":
"aaff6090b9748f9c79de161cac72d6968b5156be"}

[commit-bot: I haz the power, 2017-07-07 05:12:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499404109052140,
"parent_rev": "801d8de7fb0219622a9e653220a11a827ecbed8a", "commit_rev":
"8ba4cfa3d3beed403d349394e8569905381a21aa"}

[commit-bot: I haz the power, 2017-07-07 05:12:31]

Description was changed from

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for Shift+Click to
simplify implementation for improving code health.

Processing of Shift+Click and mouse drag are similar, we do as following:
* Shift-Click:
1. Click to set selection base at clicked position
 selection.collapse(clickedPositon)
2. Shift+Click to extend selection to clicked position
 selection.extend(clickedPoosition)

* Mouse Drag:
1. Mouse left-button down to set selection base at mouse down position.
 selection.collapse(downPosition)
2. Mouse move, holding left-button down, to extend selection to position
where move moved.
 selection.extend(movedPosition)

Step 2 of both are same, extend to position where mouse is.

BUG=692923
TEST=n/a; no behavior changes
==========

to

==========
Simplify SelectionController::UpdateSelectionForMouseDrag()

This patch changes |SelectionController::UpdateSelectionForMouseDrag()| to
utilize |AdjustPositionRespectUserSelectAll()| and
|ExtendSelectionAsDirectional()| as what we are doing for Shift+Click to
simplify implementation for improving code health.

Processing of Shift+Click and mouse drag are similar, we do as following:
* Shift-Click:
1. Click to set selection base at clicked position
 selection.collapse(clickedPositon)
2. Shift+Click to extend selection to clicked position
 selection.extend(clickedPoosition)

* Mouse Drag:
1. Mouse left-button down to set selection base at mouse down position.
 selection.collapse(downPosition)
2. Mouse move, holding left-button down, to extend selection to position
where move moved.
 selection.extend(movedPosition)

Step 2 of both are same, extend to position where mouse is.

BUG=692923
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2970043002
Cr-Commit-Position: refs/heads/master@{#484836}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ba4cfa3d3beed403d349394e856...
==========

[commit-bot: I haz the power, 2017-07-07 05:12:35]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ba4cfa3d3beed403d349394e856...