Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4064)

Unified Diff: components/payments/core/BUILD.gn

Issue 2970013003: [Payment Request] Displays appropriate footer if first transaction completed (Closed)
Patch Set: Addressed comment by mathp@ Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/core/BUILD.gn
diff --git a/components/payments/core/BUILD.gn b/components/payments/core/BUILD.gn
index c1a9b60fcd39aadd4e34147bc107898c4fa2a79c..4b9d266172bab83204a06eed4238e1e5890849b0 100644
--- a/components/payments/core/BUILD.gn
+++ b/components/payments/core/BUILD.gn
@@ -61,6 +61,8 @@ static_library("core") {
static_library("test_support") {
testonly = true
sources = [
+ "payments_test_util.cc",
Mathieu 2017/07/05 13:26:28 nit: payment_test_utils
Moe 2017/07/05 13:59:23 Hmm :? I've received the opposite feedback in the
Mathieu 2017/07/05 14:23:00 From code search test_util does seem a little more
Eugene But (OOO till 7-30) 2017/07/05 14:47:31 FWIW: _util is more prevalent than _utils
Moe 2017/07/05 16:01:46 It makes sense to move toward what's more prevalen
+ "payments_test_util.h",
"test_address_normalizer.cc",
"test_address_normalizer.h",
"test_payment_request_delegate.cc",
@@ -71,6 +73,9 @@ static_library("test_support") {
":core",
"//base",
"//components/autofill/core/browser",
+ "//components/autofill/core/browser:test_support",
+ "//components/pref_registry",
+ "//components/prefs",
]
}

Powered by Google App Engine
This is Rietveld 408576698