Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: components/payments/core/BUILD.gn

Issue 2970013003: [Payment Request] Displays appropriate footer if first transaction completed (Closed)
Patch Set: Addressed comment by mathp@ Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("core") { 5 static_library("core") {
6 sources = [ 6 sources = [
7 "address_normalization_manager.cc", 7 "address_normalization_manager.cc",
8 "address_normalization_manager.h", 8 "address_normalization_manager.h",
9 "address_normalizer.h", 9 "address_normalizer.h",
10 "address_normalizer_impl.cc", 10 "address_normalizer_impl.cc",
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 public_deps = [ 55 public_deps = [
56 "//third_party/icu", 56 "//third_party/icu",
57 "//third_party/libaddressinput", 57 "//third_party/libaddressinput",
58 ] 58 ]
59 } 59 }
60 60
61 static_library("test_support") { 61 static_library("test_support") {
62 testonly = true 62 testonly = true
63 sources = [ 63 sources = [
64 "payments_test_util.cc",
Mathieu 2017/07/05 13:26:28 nit: payment_test_utils
Moe 2017/07/05 13:59:23 Hmm :? I've received the opposite feedback in the
Mathieu 2017/07/05 14:23:00 From code search test_util does seem a little more
Eugene But (OOO till 7-30) 2017/07/05 14:47:31 FWIW: _util is more prevalent than _utils
Moe 2017/07/05 16:01:46 It makes sense to move toward what's more prevalen
65 "payments_test_util.h",
64 "test_address_normalizer.cc", 66 "test_address_normalizer.cc",
65 "test_address_normalizer.h", 67 "test_address_normalizer.h",
66 "test_payment_request_delegate.cc", 68 "test_payment_request_delegate.cc",
67 "test_payment_request_delegate.h", 69 "test_payment_request_delegate.h",
68 ] 70 ]
69 71
70 deps = [ 72 deps = [
71 ":core", 73 ":core",
72 "//base", 74 "//base",
73 "//components/autofill/core/browser", 75 "//components/autofill/core/browser",
76 "//components/autofill/core/browser:test_support",
77 "//components/pref_registry",
78 "//components/prefs",
74 ] 79 ]
75 } 80 }
76 81
77 source_set("unit_tests") { 82 source_set("unit_tests") {
78 testonly = true 83 testonly = true
79 sources = [ 84 sources = [
80 "address_normalization_manager_unittest.cc", 85 "address_normalization_manager_unittest.cc",
81 "address_normalizer_impl_unittest.cc", 86 "address_normalizer_impl_unittest.cc",
82 "autofill_payment_instrument_unittest.cc", 87 "autofill_payment_instrument_unittest.cc",
83 "basic_card_response_unittest.cc", 88 "basic_card_response_unittest.cc",
(...skipping 17 matching lines...) Expand all
101 "//components/metrics/proto", 106 "//components/metrics/proto",
102 "//components/strings:components_strings_grit", 107 "//components/strings:components_strings_grit",
103 "//components/ukm", 108 "//components/ukm",
104 "//components/ukm:test_support", 109 "//components/ukm:test_support",
105 "//testing/gmock", 110 "//testing/gmock",
106 "//testing/gtest", 111 "//testing/gtest",
107 "//third_party/libaddressinput:test_support", 112 "//third_party/libaddressinput:test_support",
108 "//ui/base", 113 "//ui/base",
109 ] 114 ]
110 } 115 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698