Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

Issue 2970003002: Add code generation for ConditionalFeatures bindings code (Closed)
Patch Set: Move awkward dependency into scripts.gni with its counterpart Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
index f77b32a2b6033cdae354b8bbc0ebc7058ab87ed6..212c958cd06d7b936ff4ca30956c4b01b941fbcd 100644
--- a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
@@ -48,7 +48,7 @@ Design doc: http://www.chromium.org/developers/design-documents/idl-compiler
import os
import posixpath
-from code_generator import CodeGeneratorBase, render_template, normalize_and_sort_includes
+from code_generator import IDLCodeGeneratorBase, render_template, normalize_and_sort_includes
from idl_definitions import Visitor
from idl_types import IdlType
import v8_callback_function
@@ -131,11 +131,11 @@ class TypedefResolver(Visitor):
self._resolve_typedefs(typed_object)
-class CodeGeneratorV8Base(CodeGeneratorBase):
+class CodeGeneratorV8Base(IDLCodeGeneratorBase):
"""Base class for v8 bindings generator and IDL dictionary impl generator"""
def __init__(self, info_provider, cache_dir, output_dir):
- CodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider, cache_dir, output_dir)
+ IDLCodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider, cache_dir, output_dir)
self.typedef_resolver = TypedefResolver(info_provider)
def generate_code(self, definitions, definition_name):
@@ -289,14 +289,14 @@ class CodeGeneratorDictionaryImpl(CodeGeneratorV8Base):
)
-class CodeGeneratorUnionType(CodeGeneratorBase):
+class CodeGeneratorUnionType(IDLCodeGeneratorBase):
"""Generates union type container classes.
This generator is different from CodeGeneratorV8 and
CodeGeneratorDictionaryImpl. It assumes that all union types are already
collected. It doesn't process idl files directly.
"""
def __init__(self, info_provider, cache_dir, output_dir, target_component):
- CodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider, cache_dir, output_dir)
+ IDLCodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider, cache_dir, output_dir)
self.target_component = target_component
# The code below duplicates parts of TypedefResolver. We do not use it
# directly because IdlUnionType is not a type defined in
@@ -356,9 +356,9 @@ class CodeGeneratorUnionType(CodeGeneratorBase):
return outputs
-class CodeGeneratorCallbackFunction(CodeGeneratorBase):
+class CodeGeneratorCallbackFunction(IDLCodeGeneratorBase):
def __init__(self, info_provider, cache_dir, output_dir, target_component):
- CodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider, cache_dir, output_dir)
+ IDLCodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider, cache_dir, output_dir)
self.target_component = target_component
self.typedef_resolver = TypedefResolver(info_provider)

Powered by Google App Engine
This is Rietveld 408576698