Add code generation for ConditionalFeatures bindings code

third_party/WebKit/Source/bindings/scripts/code_generator.py

Index: third_party/WebKit/Source/bindings/scripts/code_generator.py
diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator.py b/third_party/WebKit/Source/bindings/scripts/code_generator.py
index c9d7946ab760a5f61bb6d4c27bbfe7d942db9d22..37da45b0894d8ab59bb359a6889e8ca09a4986d4 100644
--- a/third_party/WebKit/Source/bindings/scripts/code_generator.py
+++ b/third_party/WebKit/Source/bindings/scripts/code_generator.py
@@ -121,21 +121,6 @@ class CodeGeneratorBase(object):
         self.info_provider = info_provider
         self.jinja_env = initialize_jinja_env(cache_dir)
         self.output_dir = output_dir
-        self.set_global_type_info()
-
-    def should_generate_code(self, definitions):
-        return definitions.interfaces or definitions.dictionaries
-
-    def set_global_type_info(self):
-        interfaces_info = self.info_provider.interfaces_info
-        set_ancestors(interfaces_info['ancestors'])
-        IdlType.set_callback_interfaces(interfaces_info['callback_interfaces'])
-        IdlType.set_dictionaries(interfaces_info['dictionaries'])
-        IdlType.set_enums(self.info_provider.enumerations)
-        IdlType.set_callback_functions(self.info_provider.callback_functions)
-        IdlType.set_implemented_as_interfaces(interfaces_info['implemented_as_interfaces'])
-        IdlType.set_garbage_collected_types(interfaces_info['garbage_collected_interfaces'])
-        set_component_dirs(interfaces_info['component_dirs'])
 
     def render_template(self, include_paths, header_template, cpp_template,
                         template_context, component=None):
@@ -157,6 +142,29 @@ class CodeGeneratorBase(object):
         cpp_text = render_template(cpp_template, template_context)
         return header_text, cpp_text
 
+
+class IDLCodeGeneratorBase(CodeGeneratorBase):

[Yuki, 2017/07/14 03:30:07]

Is this just a refactoring?
Does this make sense?

Is |info_provider| independent from IDLs?

|render_template| seems using only self.generator_name as a member. 
CodeGeneratorBase won't use any of info_provider, jinja_env, nor output_dir. 
Does it make sense to have CodeGeneratorBase class at all?

[iclelland, 2017/07/14 18:25:04]

I wanted to reuse some of the functionality from CodeGeneratorBase, although it
was too specifically targetted towards just generating code for a single
interface. Specifically, I wanted:
  -- Access to info_provider for a global view of the interfaces
  -- The jinja templating environment
and I didn't want the parts that assumed a single IDL type. So I split it into
two, and based the conditional features generator on the root base class.
That's a legitimate question :) It did when I started, but I had a slightly
different approach at the time (I was annotating the
interfaces_info_overall.pickle file with the origin_trials information). I will
revisit that and see what it looks like if I avoid using the CodeGenerator
classes at all.
I'm not sure what you mean by that. Are you asking whether the same information
appears in both? I suppose so, since |info_provider| provides the information
that ultimately comes from the IDL files. It's already been processed though --
partial interfaces have had their dependencies resolved, etc.

Again, maybe that's a dependency that I don't need anymore, so I'll see if I can
live without it.

+    """Base class for code generators which create bindings implementations from
+    IDL files.
+    """
+    def __init__(self, generator_name, info_provider, cache_dir, output_dir):
+        super(IDLCodeGeneratorBase, self).__init__(generator_name, info_provider, cache_dir, output_dir)
+        self.set_global_type_info()
+
+    def should_generate_code(self, definitions):
+        return definitions.interfaces or definitions.dictionaries
+
+    def set_global_type_info(self):
+        interfaces_info = self.info_provider.interfaces_info
+        set_ancestors(interfaces_info['ancestors'])
+        IdlType.set_callback_interfaces(interfaces_info['callback_interfaces'])
+        IdlType.set_dictionaries(interfaces_info['dictionaries'])
+        IdlType.set_enums(self.info_provider.enumerations)
+        IdlType.set_callback_functions(self.info_provider.callback_functions)
+        IdlType.set_implemented_as_interfaces(interfaces_info['implemented_as_interfaces'])
+        IdlType.set_garbage_collected_types(interfaces_info['garbage_collected_interfaces'])
+        set_component_dirs(interfaces_info['component_dirs'])
+
     def generate_code(self, definitions, definition_name):
         """Invokes code generation. The [definitions] argument is a list of definitions,
         and the [definition_name] is the name of the definition