Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Issue 296993004: Fixes use after free in HWNDMessageHandler (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fixes use after free in HWNDMessageHandler msg_handled_ should only be set if ref is this is still valid. BUG=374320 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/views/win/hwnd_message_handler.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 7 months ago (2014-05-22 21:41:33 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-22 21:42:03 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-22 21:43:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/296993004/1
6 years, 7 months ago (2014-05-22 21:44:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 01:08:17 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 09:51:28 UTC) #6
Message was sent while issue was closed.
Change committed as 272460

Powered by Google App Engine
This is Rietveld 408576698