ui/views/win/hwnd_message_handler.h - Issue 296993004: Fixes use after free in HWNDMessageHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/win/hwnd_message_handler.h

Issue 296993004: Fixes use after free in HWNDMessageHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/win/hwnd_message_handler.h

diff --git a/ui/views/win/hwnd_message_handler.h b/ui/views/win/hwnd_message_handler.h

index 24cd8fda66d53212e1cfbabe45a1a21ee0c17c0b..d5a5c866c9ae5f56c43d83ad3fc6b893fbf731a5 100644

--- a/ui/views/win/hwnd_message_handler.h

+++ b/ui/views/win/hwnd_message_handler.h

@@ -78,10 +78,12 @@ const int WM_NCUAHDRAWFRAME = 0xAF;

LPARAM l_param, \

LRESULT& l_result, \

DWORD msg_map_id = 0) { \

+ base::WeakPtr<HWNDMessageHandler> ref(weak_factory_.GetWeakPtr()); \

BOOL old_msg_handled = msg_handled_; \

BOOL ret = _ProcessWindowMessage(hwnd, msg, w_param, l_param, l_result, \

msg_map_id); \

- msg_handled_ = old_msg_handled; \

+ if (ref.get()) \

+ msg_handled_ = old_msg_handled; \

return ret; \

} \

BOOL _ProcessWindowMessage(HWND hWnd, \

« no previous file with comments | « no previous file | no next file » | no next file with comments »