Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2969843004: Don't show the Data Saver promo in incognito mode (Closed)

Created:
3 years, 5 months ago by megjablon
Modified:
3 years, 5 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show the Data Saver promo in incognito mode BUG=737926 Review-Url: https://codereview.chromium.org/2969843004 Cr-Commit-Position: refs/heads/master@{#485456} Committed: https://chromium.googlesource.com/chromium/src/+/7e469cba37139f2f438acbeef855923d21c731c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
megjablon
3 years, 5 months ago (2017-07-03 19:43:52 UTC) #4
megjablon
A friendly ping :) +dtrainor in case maria is ooo
3 years, 5 months ago (2017-07-06 19:01:07 UTC) #8
David Trainor- moved to gerrit
lgtm
3 years, 5 months ago (2017-07-10 22:55:49 UTC) #9
Maria
lgtm
3 years, 5 months ago (2017-07-10 23:15:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969843004/1
3 years, 5 months ago (2017-07-10 23:16:15 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 00:13:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e469cba37139f2f438acbeef855...

Powered by Google App Engine
This is Rietveld 408576698