Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2969833002: Convert DartChangeBuilder to use AnalysisSession (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-02 15:43:29 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2969833002/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart File pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart (right): https://codereview.chromium.org/2969833002/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart#newcode35 pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart:35: * The analysis driver in which the files ...
3 years, 5 months ago (2017-07-02 16:59:44 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2969833002/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart File pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart (right): https://codereview.chromium.org/2969833002/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart#newcode35 pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart:35: * The analysis driver in which the files being ...
3 years, 5 months ago (2017-07-03 15:41:22 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-07-03 15:41:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a7b9f441b97b59385383496c0f9ec1dae840a85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698