Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart

Issue 2969833002: Convert DartChangeBuilder to use AnalysisSession (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart b/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart
index 7db0bcd97d056ee676ccc9c0c90a6ffc03840942..c83e04109b8b2f168b20a4342c95c703987816ae 100644
--- a/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart
+++ b/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart
@@ -6,6 +6,7 @@ import 'dart:async';
import 'package:analysis_server/src/protocol_server.dart' hide Element;
import 'package:analysis_server/src/services/correction/util.dart';
+import 'package:analyzer/dart/analysis/session.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/dart/element/type.dart';
@@ -306,6 +307,11 @@ class PostfixCompletionProcessor {
int get selectionOffset => completionContext.selectionOffset;
+ /**
+ * Return the analysis session to be used to create the change builder.
+ */
+ AnalysisSession get session => driver.currentSession;
+
Source get source => completionContext.unitElement.source;
TypeProvider get typeProvider {
@@ -333,7 +339,7 @@ class PostfixCompletionProcessor {
return null;
}
- DartChangeBuilder changeBuilder = new DartChangeBuilder(driver);
+ DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
await changeBuilder.addFileEdit(file, (DartFileEditBuilder builder) {
builder.addReplacement(range.node(expr), (DartEditBuilder builder) {
String newSrc = sourcer(expr);
@@ -367,7 +373,7 @@ class PostfixCompletionProcessor {
if (stmt == null) {
return null;
}
- DartChangeBuilder changeBuilder = new DartChangeBuilder(driver);
+ DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
await changeBuilder.addFileEdit(file, (DartFileEditBuilder builder) {
// Embed the full line(s) of the statement in the try block.
var startLine = lineInfo.getLocation(stmt.offset).lineNumber - 1;

Powered by Google App Engine
This is Rietveld 408576698