Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2969753002: [DevTools] Split auto-attach part of TargetHandler into a separate class (Closed)
Patch Set: similarity Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 96ace3b1b619471929e37e2f736e67ba6c1192bd..16e680e9206f4b245589516c439b2c2c06139c12 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -643,7 +643,7 @@ void RenderFrameDevToolsAgentHost::DidFinishNavigation(
CommitPending();
}
for (auto* target : protocol::TargetHandler::ForAgentHost(this))
- target->UpdateServiceWorkers();
+ target->DidFinishNavigation();
caseq 2017/07/07 17:46:33 Not sure if it's fair to rename this to DidFinishN
dgozman 2017/07/13 21:46:22 Renamed to DidCommitNavigation.
} else if (pending_ && pending_->host()->GetFrameTreeNodeId() ==
navigation_handle->GetFrameTreeNodeId()) {
DiscardPending();
@@ -681,7 +681,7 @@ void RenderFrameDevToolsAgentHost::DidFinishNavigation(
}
if (handle->HasCommitted()) {
for (auto* target : protocol::TargetHandler::ForAgentHost(this))
- target->UpdateServiceWorkers();
+ target->DidFinishNavigation();
}
}
@@ -815,7 +815,7 @@ void RenderFrameDevToolsAgentHost::RenderFrameHostChanged(
RenderFrameHost* old_host,
RenderFrameHost* new_host) {
for (auto* target : protocol::TargetHandler::ForAgentHost(this))
- target->UpdateFrames();
+ target->RenderFrameHostChanged();
if (IsBrowserSideNavigationEnabled()) {
if (old_host != frame_host_)

Powered by Google App Engine
This is Rietveld 408576698