Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2969693002:
Always create safe browsing specific directory in WebView. (Closed)
|
Created:
3 years, 5 months ago by timvolodine Modified:
3 years, 5 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAlways create safe browsing specific directory in WebView.
We need to create the safe browsing directory for storing
safe browsing related cookies. This should happen in any case
as the safe browsing functionality can be enabled on a
per webview basis at runtime.
BUG=700351, 688629
Review-Url: https://codereview.chromium.org/2969693002
Cr-Commit-Position: refs/heads/master@{#485595}
Committed: https://chromium.googlesource.com/chromium/src/+/b27231d3217b7100e0a7e6759cbda079c83ac01d
Patch Set 1 #Patch Set 2 : rebase #
Depends on Patchset: Messages
Total messages: 24 (16 generated)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
timvolodine@chromium.org changed reviewers: + sgurun@chromium.org, tobiasjs@chromium.org
On 2017/06/30 14:59:56, timvolodine wrote: actually will need to clarify regarding the functionality to enable safe browsing per webview and the timeline..
lgtm
sgurun@google.com changed reviewers: + sgurun@google.com
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
Description was changed from ========== Always create safe browsing specific directory in WebView. We need to create the safe browsing directory for storing safe browsing related cookies. This should happen in any case as the safe browsing functionality can be enabled on a per webview basis at runtime. BUG=700351, 688629 ========== to ========== Always create safe browsing specific directory in WebView. We need to create the safe browsing directory for storing safe browsing related cookies. This should happen in any case as the safe browsing functionality can be enabled on a per webview basis at runtime. BUG=700351, 688629 ==========
sgurun@chromium.org changed reviewers: - sgurun@google.com
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/06/30 15:23:31, selim wrote: > lgtm checked this offline: the API for enabling on per webview basis will be there with O MR1 (with WebView M61) so will land this now.
On 2017/07/11 11:49:47, timvolodine wrote: > On 2017/06/30 15:23:31, selim wrote: > > lgtm > > checked this offline: the API for enabling on per webview basis will be there > with O MR1 (with WebView M61) so will land this now. thanks for the reviews!
The CQ bit was checked by timvolodine@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tobiasjs@chromium.org, sgurun@google.com Link to the patchset: https://codereview.chromium.org/2969693002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499773811912700,
"parent_rev": "f7fa8b0875dc211cee0fb00cec084f6215b0cb21", "commit_rev":
"b27231d3217b7100e0a7e6759cbda079c83ac01d"}
Message was sent while issue was closed.
Description was changed from ========== Always create safe browsing specific directory in WebView. We need to create the safe browsing directory for storing safe browsing related cookies. This should happen in any case as the safe browsing functionality can be enabled on a per webview basis at runtime. BUG=700351, 688629 ========== to ========== Always create safe browsing specific directory in WebView. We need to create the safe browsing directory for storing safe browsing related cookies. This should happen in any case as the safe browsing functionality can be enabled on a per webview basis at runtime. BUG=700351, 688629 Review-Url: https://codereview.chromium.org/2969693002 Cr-Commit-Position: refs/heads/master@{#485595} Committed: https://chromium.googlesource.com/chromium/src/+/b27231d3217b7100e0a7e6759cbd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b27231d3217b7100e0a7e6759cbd... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
