Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2969643003: [web] Update packages, use TS 2.4 (Closed)

Created:
3 years, 5 months ago by dnj
Modified:
3 years, 5 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[web] Update packages, use TS 2.4 Update web to use TypeScript 2.4, and fix some minor bugs that are now detected. Update some package versions to remove some deprecation warnings. BUG=chromium:737631 TEST=local Review-Url: https://codereview.chromium.org/2969643003 Committed: https://github.com/luci/luci-go/commit/778ac0b55880b89da16bcddae98765f45d08d3c7

Patch Set 1 #

Total comments: 2

Patch Set 2 : [web] Update packages, use TS 2.4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M web/apps/gulp-common.js View 3 chunks +8 lines, -6 lines 0 comments Download
M web/inc/logdog-stream-view/model.ts View 4 chunks +4 lines, -5 lines 0 comments Download
M web/inc/luci-operation/operation.ts View 1 chunk +1 line, -1 line 0 comments Download
M web/package.json View 1 2 chunks +11 lines, -5 lines 0 comments Download
M web/web.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dnj
PTAL
3 years, 5 months ago (2017-06-30 23:53:06 UTC) #2
iannucci
lgtm https://codereview.chromium.org/2969643003/diff/1/web/package.json File web/package.json (right): https://codereview.chromium.org/2969643003/diff/1/web/package.json#newcode44 web/package.json:44: "typescript": "^2.4", Do we want this to break ...
3 years, 5 months ago (2017-07-01 03:46:50 UTC) #7
dnj
https://codereview.chromium.org/2969643003/diff/1/web/package.json File web/package.json (right): https://codereview.chromium.org/2969643003/diff/1/web/package.json#newcode44 web/package.json:44: "typescript": "^2.4", On 2017/07/01 03:46:50, iannucci wrote: > Do ...
3 years, 5 months ago (2017-07-01 15:16:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969643003/20001
3 years, 5 months ago (2017-07-01 15:16:28 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-01 15:24:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/778ac0b55880b89da16bcddae98765f45d08d3c7

Powered by Google App Engine
This is Rietveld 408576698