Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2969523002: Set the web view's resize background color to transparent. (Closed)

Created:
3 years, 5 months ago by oshima
Modified:
3 years, 5 months ago
Reviewers:
vadimt, jennyz
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the web view's resize background color to transparent. The issue was that NativeViewHost fills the background with WHITE (default color) if the clipping window is installed. This was for fast resize scenario (resizing the view without resizing nativ view), but this also appends when native view gets clipped (which happens when you scroll). While it's a bit sounds wrong to set the resize background color even if you're not resizing, this is simplest solution. BUG=None Review-Url: https://codereview.chromium.org/2969523002 Cr-Commit-Position: refs/heads/master@{#486817} Committed: https://chromium.googlesource.com/chromium/src/+/d72f2eac28ff9bd62a312ef7efebb511fab56277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
oshima
3 years, 5 months ago (2017-06-29 20:41:51 UTC) #2
vadimt
lgtm Oh, super-cool; thanks!
3 years, 5 months ago (2017-07-11 00:38:57 UTC) #3
oshima
jennyz@ for owner's review
3 years, 5 months ago (2017-07-11 16:24:07 UTC) #5
jennyz
lgtm
3 years, 5 months ago (2017-07-13 22:24:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969523002/1
3 years, 5 months ago (2017-07-14 17:30:19 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 18:31:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d72f2eac28ff9bd62a312ef7efeb...

Powered by Google App Engine
This is Rietveld 408576698