Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Issue 2969473004: [Night Light] CL11: Enhancements (Closed)

Created:
3 years, 5 months ago by afakhry
Modified:
3 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, kalyank, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Night Light] CL11: Enhancements Implement requested enhancements by UI review: - Make short animation duration = 1 second. - Reduce expanded knob scale to 125%. - Prevent label bubbles from touching. - Reduce label bubble and knob distance. - Add a cubic-bezier label-bubble overlap animation. - Make knobs snap distance = 60 minutes. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c28 BUG=705816, 738101, 738102, 736875 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2969473004 Cr-Commit-Position: refs/heads/master@{#483774} Committed: https://chromium.googlesource.com/chromium/src/+/0f66f4a7c5941784cbfd8600cc36671218ef6c1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M ash/system/night_light/night_light_controller.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/device_page/night_light_slider.html View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/device_page/night_light_slider.js View 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
afakhry
Steven, could you please review this CL? Thank you!
3 years, 5 months ago (2017-06-30 00:35:19 UTC) #5
stevenjb
lgtm
3 years, 5 months ago (2017-06-30 18:27:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969473004/1
3 years, 5 months ago (2017-06-30 18:33:29 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 18:38:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f66f4a7c5941784cbfd8600cc36...

Powered by Google App Engine
This is Rietveld 408576698