Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2969473002: Stop warning "missing clientInfo.numericDate" when loading (Closed)

Created:
3 years, 5 months ago by eroman
Modified:
3 years, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews, bnc+watch_chromium.org, arv+watch_chromium.org, mmenke, eroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop warning "missing clientInfo.numericDate" when loading chrome://net-export logs. BUG=733742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2969473002 Cr-Commit-Position: refs/heads/master@{#483462} Committed: https://chromium.googlesource.com/chromium/src/+/47ccdf8f39e591062579e6fb6e37028661042fad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/browser/resources/net_internals/log_util.js View 1 chunk +17 lines, -8 lines 0 comments Download
M chrome/test/data/webui/net_internals/log_util.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
eroman
3 years, 5 months ago (2017-06-29 18:56:55 UTC) #5
mmenke
LGTM
3 years, 5 months ago (2017-06-29 19:46:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969473002/1
3 years, 5 months ago (2017-06-29 20:12:05 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 20:15:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47ccdf8f39e591062579e6fb6e37...

Powered by Google App Engine
This is Rietveld 408576698