[LayoutNG] Add min/max-{width,height} to instrinics check for abs-pos

third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc

Index: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
index 89ae6d626caa6aa24d3f16906de29b5c46522379..1320cac734bac555f974b9ec762abb8a90a0cb7c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
@@ -15,13 +15,15 @@ namespace {
 
 bool AbsoluteHorizontalNeedsEstimate(const ComputedStyle& style) {
   Length width = style.Width();
-  return width.IsIntrinsic() ||
+  return style.MinWidth().IsIntrinsic() || style.MaxWidth().IsIntrinsic() ||

[cbiesinger, 2017/06/29 20:40:01]

Why does that work? Don't we need to compute the min/max content size when min
or max width is intrinsic?

What problem does this fix? Can you expand on the CL description? :)

[ikilpatrick, 2017/06/29 22:45:07]

I've changed this so its a little more obvious... it leaves these functions
alone, but have a look at the ng_out_of_flow_part.cc

+         width.IsIntrinsic() ||
          (width.IsAuto() && (style.Left().IsAuto() || style.Right().IsAuto()));
 }
 
 bool AbsoluteVerticalNeedsEstimate(const ComputedStyle& style) {
   Length height = style.Height();
-  return height.IsIntrinsic() ||
+  return style.MinHeight().IsIntrinsic() || style.MaxHeight().IsIntrinsic() ||
+         height.IsIntrinsic() ||
          (height.IsAuto() && (style.Top().IsAuto() || style.Bottom().IsAuto()));
 }