[LayoutNG] Add min/max-{width,height} to instrinics check for abs-pos

third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_absolute_utils.h"
 
 #include "core/layout/ng/ng_constraint_space.h"
 #include "core/layout/ng/ng_length_utils.h"
 #include "core/style/ComputedStyle.h"
 #include "platform/LengthFunctions.h"
 
 namespace blink {
 
 namespace {
 
 bool AbsoluteHorizontalNeedsEstimate(const ComputedStyle& style) {
   Length width = style.Width();
-  return width.IsIntrinsic() ||
+  return style.MinWidth().IsIntrinsic() || style.MaxWidth().IsIntrinsic() ||

[cbiesinger, 2017/06/29 20:40:01]

Why does that work? Don't we need to compute the min/max content size when min
or max width is intrinsic?

What problem does this fix? Can you expand on the CL description? :)

[ikilpatrick, 2017/06/29 22:45:07]

I've changed this so its a little more obvious... it leaves these functions
alone, but have a look at the ng_out_of_flow_part.cc

+         width.IsIntrinsic() ||
          (width.IsAuto() && (style.Left().IsAuto() || style.Right().IsAuto()));
 }
 
 bool AbsoluteVerticalNeedsEstimate(const ComputedStyle& style) {
   Length height = style.Height();
-  return height.IsIntrinsic() ||
+  return style.MinHeight().IsIntrinsic() || style.MaxHeight().IsIntrinsic() ||
+         height.IsIntrinsic() ||
          (height.IsAuto() && (style.Top().IsAuto() || style.Bottom().IsAuto()));
 }
 
 LayoutUnit ResolveWidth(const Length& width,
                         const NGConstraintSpace& space,
                         const ComputedStyle& style,
                         const Optional<MinMaxContentSize>& child_minmax,
                         LengthResolveType resolve_type) {
   if (space.WritingMode() == kHorizontalTopBottom)
     return ResolveInlineLength(space, style, child_minmax, width, resolve_type);
@@ skipping 395 matching lines @@
     if (!style.Width().IsAuto()) {
       width = ResolveWidth(style.Width(), space, style, child_minmax,
                            LengthResolveType::kContentSize);
     }
     ComputeAbsoluteHorizontal(space, style, width, static_position,
                               child_minmax, position);
   }
 }
 
 }  // namespace blink