Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4084)

Unified Diff: chrome/browser/permissions/PERMISSIONS_OWNERS

Issue 2969393002: Add PERMISSIONS_OWNERS for reviewing PermissionContext subclass changes (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/OWNERS ('k') | chrome/browser/plugins/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/PERMISSIONS_OWNERS
diff --git a/chrome/browser/permissions/PERMISSIONS_OWNERS b/chrome/browser/permissions/PERMISSIONS_OWNERS
new file mode 100644
index 0000000000000000000000000000000000000000..44d11c8f600614a066973d87ff9e7b82f8d16d38
--- /dev/null
+++ b/chrome/browser/permissions/PERMISSIONS_OWNERS
@@ -0,0 +1,8 @@
+# permission_context subclasses require a Security UX review by one of the
benwells 2017/07/06 07:20:59 Nit: PermissionContext subclasses...
raymes 2017/07/11 01:57:35 Done.
+# following:
+
+benwells@chromium.org
+dominickn@chromium.org
+kcarattini@chromium.org
+raymes@chromium.org
+timloh@chromium.org
Peter Beverloo 2017/07/06 11:29:34 If you're going down the route of `set noparent` (
mlamouri (slow - plz ping) 2017/07/07 09:40:46 If that's an issue, I'm pretty sure I can review t
raymes 2017/07/11 01:57:35 Good point - I didn't think about that. I think ch
« no previous file with comments | « chrome/browser/notifications/OWNERS ('k') | chrome/browser/plugins/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698