chrome/browser/permissions/PERMISSIONS_OWNERS - Issue 2969393002: Add PERMISSIONS_OWNERS for reviewing PermissionContext subclass changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/permissions/PERMISSIONS_OWNERS

Issue 2969393002: Add PERMISSIONS_OWNERS for reviewing PermissionContext subclass changes (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # permission_context subclasses require a Security UX review by one of the
	benwells 2017/07/06 07:20:59 Nit: PermissionContext subclasses... Nit: PermissionContext subclasses... raymes 2017/07/11 01:57:35 Done. Show quoted text On 2017/07/06 07:20:59, benwells wrote: > Nit: PermissionContext subclasses... Done.
	2 # following:

	3

	4 benwells@chromium.org

	5 dominickn@chromium.org

	6 kcarattini@chromium.org

	7 raymes@chromium.org

	8 timloh@chromium.org
	Peter Beverloo 2017/07/06 11:29:34 If you're going down the route of `set noparent` ( If you're going down the route of `set noparent` (which we have a general dislike for, but you know that), it's good practice to try to grow a more geographically distributed set of OWNERS. mlamouri (slow - plz ping) 2017/07/07 09:40:46 If that's an issue, I'm pretty sure I can review t Show quoted text On 2017/07/06 at 11:29:34, Peter Beverloo wrote: > If you're going down the route of `set noparent` (which we have a general dislike for, but you know that), it's good practice to try to grow a more geographically distributed set of OWNERS. If that's an issue, I'm pretty sure I can review the PermissionContext subclasses. raymes 2017/07/11 01:57:35 Good point - I didn't think about that. I think ch Good point - I didn't think about that. I think changes to these files tend to be quite rare by non-permissions folks right now so having a geographical distribution might not be too important yet. A quick look shows only about 5-6 changes in the last 6 months by non-permissions OWNERS. Given some of the nuances in the code it might be good to have a smaller set of owners for the time being but we can expand that if needed :)
OLD	NEW

« no previous file with comments | « chrome/browser/notifications/OWNERS ('k') | chrome/browser/plugins/OWNERS » ('j') | no next file with comments »