Introduce GN to desktop_linux arg and grit_defines list.

Introduce GN to desktop_linux arg and grit_defines list.

They are necessary otherwise grit won't define IDS_WEB_FONT_FAMILY and
IDS_WEB_FONT_SIZE from app_locale_settings.grd

Which is necessary, otherwise we get the following error when trying to
compile web_ui_util.cc:

../../ui/base/webui/web_ui_util.cc:130:28: error: 'IDS_WEB_FONT_FAMILY'
was not declared in this scope
../../ui/base/webui/web_ui_util.cc:131:26: error: 'IDS_WEB_FONT_SIZE'
was not declared in this scope

BUG=367591
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn ui_base
R=brettw@chromium.org
TBR=ben (for ui/base change)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274019

[tfarina, 2014-05-23 19:38:37]

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni#newc...
build/config/ui.gni:62: grit_defines = []
in GYP this is declared in build/common.gypi.

Where in GN would be a better place for this?

[brettw, 2014-05-27 23:51:02]

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni#newc...
build/config/ui.gni:62: grit_defines = []
On 2014/05/23 19:38:37, tfarina wrote:
> in GYP this is declared in build/common.gypi.
> 
> Where in GN would be a better place for this?

I think you can just put this in the grit_rule.gni file itself, unless it needs
to be used outside of that file.

[brettw, 2014-05-27 23:54:22]

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni#newc...
build/config/ui.gni:15: desktop_linux = is_linux && !is_chromeos
Since it seems like we're stuck with this, can you put this in
build/common/BUILDCONFIG.gn where the other is_linux, etc are defined, and call
it is_desktop_linux?

[tfarina, 2014-05-30 03:02:07]

ptal

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni#newc...
build/config/ui.gni:15: desktop_linux = is_linux && !is_chromeos
On 2014/05/27 23:54:23, brettw wrote:
> Since it seems like we're stuck with this, can you put this in
> build/common/BUILDCONFIG.gn where the other is_linux, etc are defined, and
call
> it is_desktop_linux?

Done.

https://codereview.chromium.org/296933017/diff/20001/build/config/ui.gni#newc...
build/config/ui.gni:62: grit_defines = []
On 2014/05/27 23:51:03, brettw wrote:
> On 2014/05/23 19:38:37, tfarina wrote:
> > in GYP this is declared in build/common.gypi.
> > 
> > Where in GN would be a better place for this?
> 
> I think you can just put this in the grit_rule.gni file itself, unless it
needs
> to be used outside of that file.

Done.

[brettw, 2014-05-30 20:00:11]

lgtm

[tfarina, 2014-05-31 04:35:16]

Committed patchset #5 manually as r274019 (presubmit successful).