Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: build/config/ui.gni

Issue 296933017: Introduce GN to desktop_linux arg and grit_defines list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/gn/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains UI-related build flags. It should theoretically be in the 5 # This file contains UI-related build flags. It should theoretically be in the
6 # src/ui directory and only things that depend on the ui module should get the 6 # src/ui directory and only things that depend on the ui module should get the
7 # definitions. 7 # definitions.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global. 10 # e.g. base, so they need to be global.
11 # 11 #
12 # See also build/config/features.gni 12 # See also build/config/features.gni
13 13
14 declare_args() { 14 declare_args() {
15 desktop_linux = is_linux && !is_chromeos
brettw 2014/05/27 23:54:23 Since it seems like we're stuck with this, can you
tfarina 2014/05/30 03:02:07 Done.
16
15 # Indicates if Ash is enabled. Ash is the Aura Shell which provides a 17 # Indicates if Ash is enabled. Ash is the Aura Shell which provides a
16 # desktop-like environment for Aura. Requires use_aura = true 18 # desktop-like environment for Aura. Requires use_aura = true
17 use_ash = is_win || is_chromeos 19 use_ash = is_win || is_chromeos
18 20
19 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux 21 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux
20 # that does not require X11. 22 # that does not require X11.
21 use_ozone = false 23 use_ozone = false
22 24
23 # Indicates if Aura is enabled. Aura is a low-level windowing library, sort 25 # Indicates if Aura is enabled. Aura is a low-level windowing library, sort
24 # of a replacement for GDI or GTK. 26 # of a replacement for GDI or GTK.
(...skipping 24 matching lines...) Expand all
49 ui_compositor_image_transport = use_aura && is_linux 51 ui_compositor_image_transport = use_aura && is_linux
50 52
51 use_default_render_theme = use_aura || is_linux 53 use_default_render_theme = use_aura || is_linux
52 54
53 # Indicates if the UI toolkit depends on X11. 55 # Indicates if the UI toolkit depends on X11.
54 use_x11 = is_linux && !use_ozone 56 use_x11 = is_linux && !use_ozone
55 57
56 use_glib = is_linux 58 use_glib = is_linux
57 59
58 use_clipboard_aurax11 = is_linux && use_aura && use_x11 60 use_clipboard_aurax11 = is_linux && use_aura && use_x11
61
62 grit_defines = []
tfarina 2014/05/23 19:38:37 in GYP this is declared in build/common.gypi. Whe
brettw 2014/05/27 23:51:03 I think you can just put this in the grit_rule.gni
tfarina 2014/05/30 03:02:07 Done.
63 if (is_chromeos) {
64 grit_defines += [ "-D", "chromeos", "-D", "scale_factors=2x"]
65 }
66
67 if (desktop_linux) {
68 grit_defines += [ "-D", "desktop_linux" ]
69 }
OLDNEW
« no previous file with comments | « no previous file | tools/gn/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698