Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2969303002:
Fixed bug where the display height was being computed incorrectly, leading to the AppListView being… (Closed)
DescriptionFixed bug where the display height was being computed incorrectly, leading to the AppListView being displayed 48 px higher than desired.
BUG=739413
Review-Url: https://codereview.chromium.org/2969303002
Cr-Commit-Position: refs/heads/master@{#485698}
Committed: https://chromium.googlesource.com/chromium/src/+/3fb847da9e4ea7d740f050b500c8bee941520ffa
Patch Set 1 : Changed how we compute display_height. #
Messages
Total messages: 21 (16 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by newcomer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
newcomer@chromium.org changed reviewers: + xiyuan@chromium.org
This is a 1 liner bug fix. The app list view was being displayed 48 px too high. -Alex
Description was changed from ========== Fixed bug where the display height was being computed incorrectly, leading to the AppListView being displayed 48 px higher than desired. BUG=739413 ========== to ========== Fixed bug where the display height was being computed incorrectly, leading to the AppListView being displayed 48 px higher than desired. BUG=739413 ==========
newcomer@chromium.org changed reviewers: + jennyz@chromium.org - xiyuan@chromium.org
Jenny, Please take a look, this is a pretty small CL. -Alex
lgtm
The CQ bit was checked by newcomer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by newcomer@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499807715461060,
"parent_rev": "2a725ce59fd474ce68db275c6e0cc4ba9b34b0b9", "commit_rev":
"22f8e60304a968c3319e4101403631df1fddf020"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499807715461060,
"parent_rev": "073c953fe21a412e94d29799558d0a90079a5c84", "commit_rev":
"3fb847da9e4ea7d740f050b500c8bee941520ffa"}
Message was sent while issue was closed.
Description was changed from ========== Fixed bug where the display height was being computed incorrectly, leading to the AppListView being displayed 48 px higher than desired. BUG=739413 ========== to ========== Fixed bug where the display height was being computed incorrectly, leading to the AppListView being displayed 48 px higher than desired. BUG=739413 Review-Url: https://codereview.chromium.org/2969303002 Cr-Commit-Position: refs/heads/master@{#485698} Committed: https://chromium.googlesource.com/chromium/src/+/3fb847da9e4ea7d740f050b500c8... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3fb847da9e4ea7d740f050b500c8... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
