Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(44)

Issue 2969293003: Revert of Remove SequencedWorkerPool::GetNamedSequenceToken from content::CreateFileSystemContext. (Closed)

Created:
1 year, 8 months ago by Marijn Kruisselbrink
Modified:
1 year, 8 months ago
Reviewers:
fdoray, tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove usage of SequencedWorkerPool::GetNamedSequenceToken from content::CreateFileSystemContext. (patchset #1 id:1 of https://codereview.chromium.org/2883403002/ ) Reason for revert: Seems to cause data races, since different FileSystemContexts are no longer sharing the same sequence. Original issue's description: > Remove usage of SequencedWorkerPool::GetNamedSequenceToken from content::CreateFileSystemContext. > > SequencedWorkerPool is being deprecated in favor of TaskScheduler. > > BUG=667892 > > Review-Url: https://codereview.chromium.org/2883403002 > Cr-Commit-Position: refs/heads/master@{#474638} > Committed: https://chromium.googlesource.com/chromium/src/+/bb731a6137ac921a8aa465613acab752b16f4666 TBR=tzik@chromium.org,fdoray@chromium.org BUG=667892 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2969293003 Cr-Commit-Position: refs/heads/master@{#484638} Committed: https://chromium.googlesource.com/chromium/src/+/55a9844c4ce86bff603ae7662c399350e6ba6d40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/browser/fileapi/browser_file_system_helper.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Marijn Kruisselbrink
Created Revert of Remove usage of SequencedWorkerPool::GetNamedSequenceToken from content::CreateFileSystemContext.
1 year, 8 months ago (2017-07-05 21:15:03 UTC) #1
Marijn Kruisselbrink
Since not sharing the same sequence is clearly problematic in the current codebase, and I ...
1 year, 8 months ago (2017-07-05 21:25:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969293003/1
1 year, 8 months ago (2017-07-06 16:24:20 UTC) #9
commit-bot: I haz the power
1 year, 8 months ago (2017-07-06 16:57:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55a9844c4ce86bff603ae7662c39...

Powered by Google App Engine
This is Rietveld 408576698