Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2969273002: Cleaned up webWillAddPendingURL:transition: callback. (Closed)

Created:
3 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 5 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaned up webWillAddPendingURL:transition: callback. Disable fullscreen inside webState:didStartNavigation: instead of webWillAddPendingURL:transition: BUG=616244 Review-Url: https://codereview.chromium.org/2969273002 Cr-Commit-Position: refs/heads/master@{#485646} Committed: https://chromium.googlesource.com/chromium/src/+/da4f211de7a88b443033d238891d4b9bb92b10df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 5 months ago (2017-07-05 18:26:37 UTC) #3
Eugene But (OOO till 7-30)
Rohit?
3 years, 5 months ago (2017-07-07 16:31:20 UTC) #7
rohitrao (ping after 24h)
lgtm
3 years, 5 months ago (2017-07-11 11:49:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969273002/1
3 years, 5 months ago (2017-07-11 15:50:23 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 16:21:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da4f211de7a88b443033d238891d...

Powered by Google App Engine
This is Rietveld 408576698